Skip to content

test: update test to use fixtures.readKey - #16811

Closed
darahayes wants to merge 1 commit into
nodejs:masterfrom
darahayes:update-test-regress-GH-1531
Closed

test: update test to use fixtures.readKey#16811
darahayes wants to merge 1 commit into
nodejs:masterfrom
darahayes:update-test-regress-GH-1531

Conversation

@darahayes

@darahayesdarahayes commented Nov 6, 2017

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines (leaving this unchecked because I'm not 100% sure - this is my first PR)
Affected core subsystem(s)

test: test/parallel/test-regress-GH-1531.js

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
cjihrig
cjihrig approved these changes Nov 6, 2017
View reviewed changes
Comment threadtest/parallel/test-regress-GH-1531.js Outdated

@cjihrigcjihrigNov 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind moving the See ... to a new line to stay under 80 characters.

@darahayesdarahayesNov 6, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjihrig No problem at all!

@cjihrigcjihrigNov 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mscdexmscdex added the https Issues or PRs related to the https subsystem. label Nov 6, 2017
@gireeshpunathilgireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2017
@Trott

Trott commented Nov 6, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11239/

Trott pushed a commit to Trott/io.js that referenced this pull request Nov 7, 2017
Dara Hayes@Trott
test: update test to use fixtures.readKey
207b24a
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-nodejsGH-1531.
PR-URL: nodejs#16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Nov 7, 2017

Copy link
Copy Markdown
Member

Landed in 207b24a.
Thanks for the contribution! 🎉

@TrottTrott closed this Nov 7, 2017
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 7, 2017
Dara Hayes@cjihrig
test: update test to use fixtures.readKey
ef67980
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-nodejsGH-1531.
PR-URL: nodejs#16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrigcjihrig mentioned this pull request Nov 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Dara Hayes@MylesBorins
test: update test to use fixtures.readKey
5e4ce5c
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.
PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Dara Hayes@MylesBorins
test: update test to use fixtures.readKey
5719bea
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.
PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 21, 2017
Merged
@gibfahngibfahn mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
Dara Hayes@MylesBorins
test: update test to use fixtures.readKey
d28737b
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.
PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
Dara Hayes@MylesBorins
test: update test to use fixtures.readKey
9f9e824
Use fixtures.readKey() rather than common.fixturesDir in
test-regress-GH-1531.
PR-URL: #16811
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@TrottTrottTrott approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+1 more reviewer
@apapirovskiapapirovskiapapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.httpsIssues or PRs related to the https subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@darahayes@Trott@apapirovski@cjihrig@gireeshpunathil@mscdex@MylesBorins@nodejs-github-bot