First time contribution from NodeConf EU

[paulashfield]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

[apapirovski]

Thanks @paulashfield — just some minor feedback below.

[apapirovski]

This would be a bit nicer as just, say:

constval1=41.92;constval2=0.08;

[apapirovski]

This could be then rewritten as:

constactual=addon.testNapiRun(`(${val1} + ${val2});`);

[apapirovski]

This could then be const expected = val1 + val2;

[apapirovski]

Here you could remove the third argument (the error message) as the default message communicates the same thing.

[gireeshpunathil]

@paulashfield -
looks like you pushed changed without:

#git config --global user.name
#git config --global user.email

on your system - implication of which is that this commit will not be associated with your profile. Can you set them up and push once again?

[vsemozhetbyt]

@paulashfield See also the last note in this chapter: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#setting-up-your-local-environment

[vsemozhetbyt]

A nit: the last line seems lacking the last line break.

[paulashfield]

Many thanks all for feedback - really helped. I have amended and recommitted, hope that looks better.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/11285/

[Trott]

Hi @paulashfield! Welcome and thanks for the PR! If you run make lint-js (or vcbuild lint-js if you're on Windows), you will see a report of a linting error on line 15. Could you fix that up?

[Trott]

Needs spacing flagged by linter fixed...

[Trott]

Because the lint issue was just about adding two spaces, I went ahead and did it myself. Hope that's OK.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/11303/

[Trott]

Landed in 3ee524b.
Thanks for the contribution! 🎉

[gibfahn]

@paulashfield just an FYI, this commit isn't associated with your Github account. You need to go to https://github.com/settings/emails and add paul.ashfield@intercity.technology. Then all your commits will be associated with you.

That's why there's a ? next to your name on the commit: 3ee524b