Uh oh!
There was an error while loading. Please reload this page.
doc: improve documentation for the vm module - #16867
Closed
fhinkel wants to merge 1 commit into
Closed
Conversation
fhinkelforce-pushed
the
nov/explain-contextify
branch
from
November 7, 2017 18:13
33b1644 to
73470c9Comparebengl
reviewed
Nov 7, 2017
Member
There was a problem hiding this comment.
Maybe:
The sandboxed code uses a different V8 Context, meaning...
cjihrig
approved these changes
Nov 7, 2017
Contributor
There was a problem hiding this comment.
Maybe "recorded on" -> "reflected in"
fhinkelforce-pushed
the
nov/explain-contextify
branch
from
November 7, 2017 20:48
73470c9 to
3313580Comparefhinkelforce-pushed
the
nov/explain-contextify
branch
from
November 8, 2017 06:14
3313580 to
ed0f7c8Comparejasnell
reviewed
Nov 8, 2017
Member
There was a problem hiding this comment.
Nit: please avoid the use of informal pronouns like you in the docs :-)
gireeshpunathil
approved these changes
Nov 8, 2017
lpinca
approved these changes
Nov 8, 2017
Add an intro section and example for the vm module.
fhinkelforce-pushed
the
nov/explain-contextify
branch
from
November 8, 2017 18:44
ed0f7c8 to
76276f0Comparefhinkel
commented
Nov 9, 2017
MemberAuthor
Thanks for the reviews. Landed in 5e1e460 |
fhinkel added a commit
that referenced
this pull request
Nov 9, 2017
Add an intro section and example for the vm module. PR-URL: #16867 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas pushed a commit
that referenced
this pull request
Nov 13, 2017
Add an intro section and example for the vm module. PR-URL: #16867 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2017
Add an intro section and example for the vm module. PR-URL: #16867 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2017
Add an intro section and example for the vm module. PR-URL: #16867 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
commented
Nov 17, 2017
Contributor
@fhinkel I've landed this on both v6.x and v8.x please lmk if this isn't appropriate for those release lines |
Merged
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 21, 2017
Add an intro section and example for the vm module. PR-URL: #16867 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 28, 2017
Add an intro section and example for the vm module. PR-URL: #16867 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think an intro section would help the vm documentation.
Checklist
make lint(UNIX) passesAffected core subsystem(s)
doc