Uh oh!
There was an error while loading. Please reload this page.
deps: cherry-pick 3c8195d from V8 upstream - #16897
Closed
fhinkel wants to merge 1 commit into
Closed
Conversation
fhinkelforce-pushed
the
nov/backport-map-error-fix
branch
2 times, most recently
from
November 9, 2017 05:17
a681714 to
be55877Comparebnoordhuis
approved these changes
Nov 9, 2017
cjihrig
approved these changes
Nov 9, 2017
jasnell
approved these changes
Nov 10, 2017
targos
commented
Nov 10, 2017
Member
Can this one be merged to 6.2 and 6.3 on V8 side? |
targos
approved these changes
Nov 10, 2017
MemberAuthor
@targos I openend a merge request: https://bugs.chromium.org/p/v8/issues/detail?id=7071 🤔 When I opened this PR, I assumed we can't merge to stable (62) upstream. But it's a correctness fix, so we should merge upstream. Waiting for feedback from V8 PMs on Monday. |
fhinkelforce-pushed
the
nov/backport-map-error-fix
branch
from
November 11, 2017 08:57
be55877 to
a2e78abCompareOriginal commit message: [map] Fix map constructor to correctly throw. We need to throw before rethrowing, otherwise the exception does not trigger a debugger event and is not reported if uncaught. R=gsathya@chromium.org, jgruber@chromium.org Bug: v8:7047 Change-Id: I7ce0253883a21d6059e4e0ed0fc56dc55a0dcba6 Reviewed-on: https://chromium-review.googlesource.com/758372 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#49237} Fixes: nodejs#16856
fhinkelforce-pushed
the
nov/backport-map-error-fix
branch
from
November 12, 2017 11:01
a2e78ab to
9bf0ffaCompare Merged
fhinkel
commented
Nov 14, 2017
MemberAuthor
This is not a critical fix so we cant back-merge it to 6.2 upstream. Landed in e7f30db. |
fhinkel added a commit
that referenced
this pull request
Nov 14, 2017
Original commit message: [map] Fix map constructor to correctly throw. We need to throw before rethrowing, otherwise the exception does not trigger a debugger event and is not reported if uncaught. R=gsathya@chromium.org, jgruber@chromium.org Bug: v8:7047 Change-Id: I7ce0253883a21d6059e4e0ed0fc56dc55a0dcba6 Reviewed-on: https://chromium-review.googlesource.com/758372 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#49237} PR-URL: #16897Fixes: #16856 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
evanlucas pushed a commit
that referenced
this pull request
Nov 14, 2017
Original commit message: [map] Fix map constructor to correctly throw. We need to throw before rethrowing, otherwise the exception does not trigger a debugger event and is not reported if uncaught. R=gsathya@chromium.org, jgruber@chromium.org Bug: v8:7047 Change-Id: I7ce0253883a21d6059e4e0ed0fc56dc55a0dcba6 Reviewed-on: https://chromium-review.googlesource.com/758372 Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#49237} PR-URL: #16897Fixes: #16856 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
commented
Nov 23, 2017
Member
This was landed without a CI run and the new test is failing on master: https://ci.nodejs.org/job/node-test-commit-v8-linux/1072/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
[map] Fix map constructor to correctly throw.
We need to throw before rethrowing, otherwise the exception does
not trigger a debugger event and is not reported if uncaught.
R=gsathya@chromium.org, jgruber@chromium.org
Bug: v8:7047
Change-Id: I7ce0253883a21d6059e4e0ed0fc56dc55a0dcba6
Reviewed-on: https://chromium-review.googlesource.com/758372
Reviewed-by: Jakob Gruber jgruber@chromium.org
Reviewed-by: Sathya Gunasekaran gsathya@chromium.org
Commit-Queue: Yang Guo yangguo@chromium.org
Cr-Commit-Position: refs/heads/master@{#49237}
Fixes: #16856
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
deps