Skip to content

doc: clarify the prerequisites for building with VS2017 - #16903

Closed
seishun wants to merge 0 commit into
nodejs:masterfrom
seishun:vs2017-req
Closed

doc: clarify the prerequisites for building with VS2017#16903
seishun wants to merge 0 commit into
nodejs:masterfrom
seishun:vs2017-req

Conversation

@seishun

@seishunseishun commented Nov 9, 2017

Copy link
Copy Markdown
Contributor
  • "Edition" is ambiguous. For example, Visual Studio Team Explorer 2017
    is listed under "Visual Studio 2017", but Build Tools for Visual
    Studio 2017 is listed under "Other Tools and Frameworks".
  • The listed required components are insufficient. VS2017 also needs
    "Visual Studio C++ core features", and Build Tools also needs
    "Visual C++ Build Tools core features".
  • Installing the workload with the default optional components takes up
    only about 1GB more space than the minimal set of components, but
    saves scrolling through the long list of individual components.
Checklist
Affected core subsystem(s)

doc

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 9, 2017
@mscdexmscdex added the windows Issues and PRs related to the Windows platform. label Nov 9, 2017
@seishun

seishun commented Nov 10, 2017

Copy link
Copy Markdown
ContributorAuthor

@nodejs/platform-windows I'm going to land this in 24 hours if there are no objections.

joaocgreis
joaocgreis approved these changes Nov 10, 2017
View reviewed changes

@joaocgreisjoaocgreis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of components that was here was exactly what was needed when those lines landed, anything else was pulled as dependencies. The installer changed, so referring to workloads instead makes more sense. Having a minimal list would be very useful for some users, but since it may change over time it's better to have this.

@richardlau

richardlau commented Nov 10, 2017

Copy link
Copy Markdown
Member

FYI this matches this screenshot of the installer I took back in September:

image

@refack

refack commented Nov 10, 2017

Copy link
Copy Markdown
Contributor

We should find a way to follow MSVS installer updates. ATM I only track vswhere changes...

seishun added a commit that referenced this pull request Nov 11, 2017
@seishun
doc: clarify the prerequisites for building with VS2017
ff21851
* "Edition" is ambiguous. For example, Visual Studio Team Explorer 2017
is listed under "Visual Studio 2017", but Build Tools for Visual
Studio 2017 is listed under "Other Tools and Frameworks".
* The listed required components are insufficient. VS2017 also needs
"Visual Studio C++ core features", and Build Tools also needs
"Visual C++ Build Tools core features".
* Installing the workload with the default optional components takes up
only about 1GB more space than the minimal set of components, but
saves scrolling through the long list of individual components.
PR-URL: #16903
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@seishunseishun closed this Nov 11, 2017
@seishun

seishun commented Nov 11, 2017

Copy link
Copy Markdown
ContributorAuthor

Landed in ff21851.

@addaleax

addaleax commented Nov 11, 2017

Copy link
Copy Markdown
Member

@seishun@refack Funny, I ran into the problem of not having all needed components on Windows yesterday & just saw this PR right now – Thank you a lot for this! ❤️

@refack

refack commented Nov 11, 2017

Copy link
Copy Markdown
Contributor

@addaleax do you remember what was missing? Did you base your setup on the old instructions?
Anyway there's a plan to supply some scripts to automate dev setup on Windows.

@addaleax

addaleax commented Nov 11, 2017

Copy link
Copy Markdown
Member

@refack Uh… This is partly from memory, but it was something like msbuild complaining about C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/Common7/IDE/VC/VCTargets/Microsoft.Cpp.props missing or so? It definitely was some C++-specific file in that folder that wasn’t part of the minimal list of required components

@seishun
seishun deleted the vs2017-req branch November 12, 2017 15:48
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@seishun@evanlucas
doc: clarify the prerequisites for building with VS2017
74f3372
* "Edition" is ambiguous. For example, Visual Studio Team Explorer 2017
is listed under "Visual Studio 2017", but Build Tools for Visual
Studio 2017 is listed under "Other Tools and Frameworks".
* The listed required components are insufficient. VS2017 also needs
"Visual Studio C++ core features", and Build Tools also needs
"Visual C++ Build Tools core features".
* Installing the workload with the default optional components takes up
only about 1GB more space than the minimal set of components, but
saves scrolling through the long list of individual components.
PR-URL: #16903
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@evanlucasevanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@seishun@MylesBorins
doc: clarify the prerequisites for building with VS2017
8f0793f
* "Edition" is ambiguous. For example, Visual Studio Team Explorer 2017
is listed under "Visual Studio 2017", but Build Tools for Visual
Studio 2017 is listed under "Other Tools and Frameworks".
* The listed required components are insufficient. VS2017 also needs
"Visual Studio C++ core features", and Build Tools also needs
"Visual C++ Build Tools core features".
* Installing the workload with the default optional components takes up
only about 1GB more space than the minimal set of components, but
saves scrolling through the long list of individual components.
PR-URL: #16903
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins

MylesBorins commented Nov 17, 2017

Copy link
Copy Markdown
Contributor

Landed on 8.x but not 6.x

If I recall we don't support VS2017 on 6.x, please correct me if mistaken

@seishun

seishun commented Nov 17, 2017

Copy link
Copy Markdown
ContributorAuthor

@MylesBorins correct.

@gibfahngibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@richardlaurichardlaurichardlau approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+2 more reviewers
@refackrefackrefack approved these changes
@joaocgreisjoaocgreisjoaocgreis approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@seishun@richardlau@refack@addaleax@MylesBorins@joaocgreis@jasnell@gireeshpunathil@mscdex@nodejs-github-bot