Skip to content

Modified method console.log of loop.js; - #16912

Closed
Anaweshak wants to merge 2 commits into
nodejs:masterfrom
Anaweshak:test
Closed

Modified method console.log of loop.js;#16912
Anaweshak wants to merge 2 commits into
nodejs:masterfrom
Anaweshak:test

Conversation

@Anaweshak

@AnaweshakAnaweshak commented Nov 10, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 10, 2017
sreepurnajasti
sreepurnajasti reviewed Nov 10, 2017
View reviewed changes
Comment threadtest/fixtures/loop.js Outdated
if (t++ === 1000) {
t = 0;
console.log('Outputed message #' + k++);
console.log(`Outputed message #${k++});

@sreepurnajastisreepurnajastiNov 10, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed closing back-tick ( ` ). Rest SGTM.

@gireeshpunathilgireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 10, 2017
@fhinkel

fhinkel commented Nov 11, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11355/

@fhinkel

fhinkel commented Nov 11, 2017

Copy link
Copy Markdown
Member

@Anaweshak Thanks so much for your first commit 🎉. Landed as fa86eba.

@fhinkelfhinkel closed this Nov 11, 2017
fhinkel pushed a commit that referenced this pull request Nov 11, 2017
@Anaweshak@fhinkel
test: change concatenated string to template
fa86eba
PR-URL: #16912
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@Anaweshak@evanlucas
test: change concatenated string to template
1ea546c
PR-URL: #16912
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@evanlucasevanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@Anaweshak@MylesBorins
test: change concatenated string to template
91e2ed4
PR-URL: #16912
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@Anaweshak@MylesBorins
test: change concatenated string to template
7168a7e
PR-URL: #16912
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@gibfahngibfahn mentioned this pull request Nov 21, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@Anaweshak@MylesBorins
test: change concatenated string to template
b65ff6e
PR-URL: #16912
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@Anaweshak@MylesBorins
test: change concatenated string to template
79dfc3f
PR-URL: #16912
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+2 more reviewers
@sreepurnajastisreepurnajastisreepurnajasti left review comments
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Anaweshak@fhinkel@jasnell@cjihrig@tniessen@gireeshpunathil@vsemozhetbyt@sreepurnajasti@MylesBorins@nodejs-github-bot