Skip to content

Minor change at line 137 in test/fixtures/guess-hash-seed.js - #16913

Closed
tanvikini wants to merge 1 commit into
nodejs:masterfrom
tanvikini:printchg
Closed

Minor change at line 137 in test/fixtures/guess-hash-seed.js#16913
tanvikini wants to merge 1 commit into
nodejs:masterfrom
tanvikini:printchg

Conversation

@tanvikini

@tanvikinitanvikini commented Nov 10, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 10, 2017
lpinca
lpinca reviewed Nov 10, 2017
View reviewed changes
Comment threadtest/fixtures/guess-hash-seed.js Outdated

@lpincalpincaNov 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The space after # should be removed.

@tanvikinitanvikiniNov 10, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorporated the mentioned change. PTAL. Many Thanks.

@gireeshpunathilgireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 10, 2017
@mscdexmscdex added the crypto Issues and PRs related to the crypto subsystem. label Nov 10, 2017
@lpinca

lpinca commented Nov 10, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11333/

@fhinkel

fhinkel commented Nov 11, 2017

Copy link
Copy Markdown
Member

CI failures unrelated.

@tanvikini Thanks so much for your first commit 🎉. Landed as
0e003a3

@fhinkelfhinkel closed this Nov 11, 2017
fhinkel pushed a commit that referenced this pull request Nov 11, 2017
@tanvikini@fhinkel
test: replace string concatenation with template
0e003a3
PR-URL: #16913
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@tanvikini@evanlucas
test: replace string concatenation with template
fbc7451
PR-URL: #16913
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@evanlucasevanlucas mentioned this pull request Nov 13, 2017
Merged
@tanvikini
tanvikini deleted the printchg branch November 15, 2017 06:07
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@tanvikini@MylesBorins
test: replace string concatenation with template
0f85885
PR-URL: #16913
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@tanvikini@MylesBorins
test: replace string concatenation with template
be920aa
PR-URL: #16913
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@gibfahngibfahn mentioned this pull request Nov 21, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@tanvikini@MylesBorins
test: replace string concatenation with template
99d0f02
PR-URL: #16913
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@tanvikini@MylesBorins
test: replace string concatenation with template
9d4abaa
PR-URL: #16913
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+1 more reviewer
@vipinmenonvipinmenonvipinmenon approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.cryptoIssues and PRs related to the crypto subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@tanvikini@lpinca@fhinkel@jasnell@cjihrig@tniessen@gireeshpunathil@vipinmenon@mscdex@MylesBorins@nodejs-github-bot