Skip to content

test: enable mustCall() during child exit - #16915

Closed
vipinmenon wants to merge 1 commit into
nodejs:masterfrom
vipinmenon:mustCall
Closed

test: enable mustCall() during child exit#16915
vipinmenon wants to merge 1 commit into
nodejs:masterfrom
vipinmenon:mustCall

Conversation

@vipinmenon

@vipinmenonvipinmenon commented Nov 10, 2017

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

Enabling mustCall() for child process on exit.

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 10, 2017
@mscdexmscdex added the process Issues and PRs related to the process subsystem. label Nov 10, 2017
@gireeshpunathil

gireeshpunathil commented Nov 10, 2017

Copy link
Copy Markdown
Member

CI: CI: https://ci.nodejs.org/job/node-test-pull-request/11331/

@gireeshpunathilgireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 10, 2017
@fhinkel

fhinkel commented Nov 11, 2017

Copy link
Copy Markdown
Member

@vipinmenon Thans! Landed in 2bd0133.

CI failures unrelated.

@fhinkelfhinkel closed this Nov 11, 2017
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@vipinmenon@evanlucas
test: enable mustCall() during child exit
407eb6f
PR-URL: #16915
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@evanlucasevanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@vipinmenon@MylesBorins
test: enable mustCall() during child exit
81a6c4f
PR-URL: #16915
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@vipinmenon@MylesBorins
test: enable mustCall() during child exit
b593d5e
PR-URL: #16915
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
@gibfahngibfahn mentioned this pull request Nov 21, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@vipinmenon@MylesBorins
test: enable mustCall() during child exit
ecf7b21
PR-URL: #16915
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@vipinmenon@MylesBorins
test: enable mustCall() during child exit
969defa
PR-URL: #16915
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fhinkelfhinkelfhinkel approved these changes
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+2 more reviewers
@apapirovskiapapirovskiapapirovski approved these changes
@XadillaXXadillaXXadillaX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.processIssues and PRs related to the process subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@vipinmenon@gireeshpunathil@fhinkel@apapirovski@jasnell@cjihrig@XadillaX@mscdex@MylesBorins@nodejs-github-bot