Uh oh!
There was an error while loading. Please reload this page.
crypto: fix legacy SNICallback - #1720
Closed
indutny wants to merge 1 commit into
Closed
Conversation
indutny
commented
May 17, 2015
MemberAuthor
cc @socketpair |
socketpair
commented
May 17, 2015
Contributor
mkey, what about tests :) ? |
indutny
commented
May 17, 2015
MemberAuthor
You actually already wrote one :) Haha. |
indutny
commented
May 29, 2015
MemberAuthor
@bnoordhuis cc |
bnoordhuis
commented
Jun 2, 2015
Member
@indutny Can you add a regression test? Maybe use Aside, is there a reason for the existence of |
`onselect` is set on the `sniObject_` not on the `Connection` instance. See: nodejs/node-v0.x-archive#25109 PR-URL: nodejs#1720 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
indutny
commented
Jul 22, 2015
MemberAuthor
Added a test, running CI. |
indutny
commented
Jul 22, 2015
MemberAuthor
indutny added a commit
that referenced
this pull request
Jul 22, 2015
`onselect` is set on the `sniObject_` not on the `Connection` instance. See: nodejs/node-v0.x-archive#25109 PR-URL: #1720 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
indutny
commented
Jul 22, 2015
MemberAuthor
Landed in eb35968, thank you everyone! |
This was referenced Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onselectis set on thesniObject_not on theConnectioninstance.See: nodejs/node-v0.x-archive#25109