Uh oh!
There was an error while loading. Please reload this page.
test: Update test-http-response-status-message to use countdown timer - #17326
Closed
daxlab wants to merge 1 commit into
Closed
test: Update test-http-response-status-message to use countdown timer#17326daxlab wants to merge 1 commit into
daxlab wants to merge 1 commit into
Conversation
daxlabforce-pushed
the
test-http-response-status-message
branch
from
November 26, 2017 17:51
57f3420 to
3e476ccComparemaclover7
approved these changes
Nov 26, 2017
Trott
commented
Nov 28, 2017
Member
If I'm not mistaken, this and the other should be "Refs" for that issue and not "Fixes". |
maclover7
commented
Dec 4, 2017
Contributor
jasnell
approved these changes
Dec 5, 2017
maclover7
commented
Dec 8, 2017
Contributor
3 tasks
apapirovski
left a comment
Contributor
There was a problem hiding this comment.
Hi @daxlab — thanks for taking this on! This is a good start but right now this test is still not using Countdown to its full potential. Instead of passing around testCaseIndex, we could just use testCases.length - countdown.remaining for the index and the check for runTest could be countdown.remaining > 0.
Let me know if you have any questions!
BridgeAR
approved these changes
Dec 10, 2017
BridgeAR
left a comment
Member
There was a problem hiding this comment.
LGTM but it would be good to get the suggestion from @apapirovski in as well.
maclover7
commented
Dec 19, 2017
Contributor
ping @daxlab |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 21, 2018
PR-URL: nodejs#17326 Refs: nodejs#17169 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
commented
Jan 21, 2018
Member
Landed in 7d2b08a |
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#17326 Refs: nodejs#17169 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #17169
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)