deps: update V8 to 6.4

[targos]

Floating two patches that have not yet landed upstream:

• https://chromium-review.googlesource.com/c/v8/v8/+/804554
  • Merge request: https://bugs.chromium.org/p/v8/issues/detail?id=7191
• https://chromium-review.googlesource.com/c/v8/v8/+/806774
  • Merge request: https://bugs.chromium.org/p/v8/issues/detail?id=7198

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

V8, build

CI: https://ci.nodejs.org/job/node-test-pull-request/11908/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1101/

[MylesBorins]

Failures in the V8 CI looks related to a test runner change

08:07:26 run-tests.py: error: no such option: --noi18n

edit:

Benchmark machine is showing a different failure

07:52:29 In file included from ../src/setup-isolate-full.cc:7:
07:52:29 .././src/base/logging.h:8:10: fatal error: 'cstring' file not found
07:52:29 #include <cstring>
07:52:29 ^~~~~~~~~
07:52:29 In file included from ../src/base/cpu.cc:5:
07:52:29 In file included from .././src/base/cpu.h:16:
07:52:29 In file included from .././src/base/base-export.h:8:
07:52:29 .././include/v8config.h:16:11: fatal error: 'features.h' file not found
07:52:29 # include <features.h>
07:52:29 ^~~~~~~~~~~~
07:52:29 In file included from ../src/base/bits.cc:5:
07:52:29 .././src/base/bits.h:9:10: fatal error: 'type_traits' file not found
07:52:29 #include <type_traits>
07:52:29 ^~~~~~~~~~~~~
07:52:29 In file included from ../src/base/debug/stack_trace.cc:5:
07:52:29 .././src/base/debug/stack_trace.h:13:10: fatal error: 'iosfwd' file not found
07:52:29 #include <iosfwd>
07:52:29 ^~~~~~~~
07:52:29 1 error generated.
07:52:29 In file included from ../src/base/division-by-constant.cc:5:
07:52:29 In file included from .././src/base/division-by-constant.h:10:
07:52:29 In file included from .././src/base/base-export.h:8:
07:52:29 .././include/v8config.h:16:11: fatal error: 'features.h' file not found
07:52:29 # include <features.h>
07:52:29 ^~~~~~~~~~~~
07:52:29 make[2]: *** [/home/iojs/build/workspace/node-test-commit-v8-linux/nodes/benchmark/v8test/v8test/deps/v8/out/x64.release/obj.target/v8_libbase/src/base/cpu.o] Error 1
07:52:29 make[2]: *** Waiting for unfinished jobs....

[MylesBorins]

Windows failures are expected, we will no longer support VS2015 with the 6.4 release. We need to update CI to account for this

ARM failures are all infra related

[MylesBorins]

/cc @nodejs/build for the benchmark failures that look gcc related

[targos]

Rerunning Windows: https://ci.nodejs.org/job/node-test-commit-windows-fanned/14092/

[targos]

Patches landed upstream in 6.4.388.8

New CI: https://ci.nodejs.org/job/node-test-pull-request/12125/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1118/

[targos]

Just pushed a fix for SmartOS and the V8 test runner:

https://ci.nodejs.org/job/node-test-commit-smartos/13984/
https://ci.nodejs.org/job/node-test-commit-v8-linux/1119/

Edit: new fix, trying again: https://ci.nodejs.org/job/node-test-commit-v8-linux/1124/

[targos]

i18n issue is fixed.

Compilation is still consistently failing on the benchmark machine. Does anyone understand this?

https://ci.nodejs.org/job/node-test-commit-v8-linux/1125/

[bnoordhuis]

It looks as if the bundled clang is looking in the wrong place for system headers. Does this patch help?

diff --git a/Makefile b/Makefile
index 992af02768..5b8cdfd685 100644
--- a/Makefile+++ b/Makefile@@ -29,6 +29,7 @@ ifdef ENABLE_V8_TAP
TAP_V8_BENCHMARKS := --junitout $(PWD)/v8-benchmarks-tap.xml
endif
+V8_BUILD_OPTIONS += GYPFLAGS="-Dclang=0"
V8_TEST_OPTIONS = $(V8_EXTRA_TEST_OPTIONS)
ifdef DISABLE_V8_I18N
V8_TEST_OPTIONS += --noi18n

[targos]

Let's try: https://ci.nodejs.org/job/node-test-commit-v8-linux/1127/

[bnoordhuis]

08:18:36 === All tests succeeded

\o/

[targos]

@bnoordhuis Is it something that I should keep in this PR (if so, can you please help me to write the commit message?) or should it be only set for the affected build bot?

[bnoordhuis]

I'd keep it. Google's bundled clang is not useful to us because that's not what our users use to compile node.js. As to the commit log: maybe this?

build: compile v8 using system compiler

Stop using the copy of clang that is bundled with Google's build tools and start using the compiler that is installed on the buildbots. It stopped working on one of the machines because it looked in the wrong place for system headers and is not representative of how users build Node.js on their systems.

[targos]

Thank you. PR updated.

CI: https://ci.nodejs.org/job/node-test-pull-request/12230/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/1130/

[targos]

Marking as blocked until V8 6.4 is stable (Jan 23rd, 2018).