Uh oh!
There was an error while loading. Please reload this page.
doc: mention node-test-pull-request-lite job - #17513
Closed
maclover7 wants to merge 2 commits into
Closed
Conversation
Contributor
LinuxONE includes doc building test, right? Does this job suffice for doc-only PRs? |
maclover7
commented
Dec 7, 2017
ContributorAuthor
@vsemozhetbyt Hmm, interesting question. My initial thought is that yes, it would be okay, although this is probably something that would need a separate issue opened for more discussion. |
Trott
approved these changes
Dec 7, 2017
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM. Maybe instead of "quick fixes" say "trivial changes" or even "trivial doc-only changes"?
cjihrig
approved these changes
Dec 7, 2017
lpinca
approved these changes
Dec 7, 2017
maclover7
commented
Dec 7, 2017
ContributorAuthor
Trott
commented
Dec 7, 2017
Member
CI: https://ci.nodejs.org/job/node-test-pull-request-lite/5/ (See what I did there?) |
maclover7
commented
Dec 8, 2017
ContributorAuthor
Landing... |
maclover7
commented
Dec 8, 2017
ContributorAuthor
Landed in de3a7db |
MylesBorins pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17513 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17513 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
gibfahn pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17513 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17513 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Closed
gibfahn pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17513 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc