Skip to content

src: remove unused include node_crypto_clienthello - #17546

Closed
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:remove-unused-include-node_crypto_clienthello.h
Closed

src: remove unused include node_crypto_clienthello#17546
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:remove-unused-include-node_crypto_clienthello.h

Conversation

@danbev

Copy link
Copy Markdown
Contributor

This commit removes the include of node.h which does not seem to be
used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

This commit removes the include of node.h which does not seem to be
used.
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Dec 8, 2017
@danbev

Copy link
Copy Markdown
ContributorAuthor

@danbev

Copy link
Copy Markdown
ContributorAuthor

@danbev

Copy link
Copy Markdown
ContributorAuthor

Landed in 7bb2cc4.

@danbevdanbev closed this Dec 11, 2017
@danbev
danbev deleted the remove-unused-include-node_crypto_clienthello.h branch December 11, 2017 12:05
danbev added a commit that referenced this pull request Dec 11, 2017
This commit removes the include of node.h which does not seem to be
used.
PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
This commit removes the include of node.h which does not seem to be
used.
PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
This commit removes the include of node.h which does not seem to be
used.
PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be
used.
PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be
used.
PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be
used.
PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
@MylesBorinsMylesBorins mentioned this pull request Dec 20, 2017
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
This commit removes the include of node.h which does not seem to be
used.
PR-URL: #17546
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@danbev@bnoordhuis@cjihrig@gibfahn@nodejs-github-bot