Uh oh!
There was an error while loading. Please reload this page.
doc: note that randomBytes throws when passed null - #17594
Closed
tniessen wants to merge 1 commit into
Closed
Conversation
apapirovski
approved these changes
Dec 10, 2017
Trott
approved these changes
Dec 10, 2017
cjihrig
approved these changes
Dec 11, 2017
BridgeAR
approved these changes
Dec 11, 2017
lpinca
approved these changes
Dec 12, 2017
danbev
approved these changes
Dec 12, 2017
maclover7
approved these changes
Dec 12, 2017
maclover7
commented
Dec 12, 2017
Contributor
Member
Landed in 2c77cab |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Dec 12, 2017
Fixes: nodejs#16778 PR-URL: nodejs#17594Fixes: nodejs#16778 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit
that referenced
this pull request
Jan 8, 2018
Fixes: #16778 PR-URL: #17594Fixes: #16778 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in the issue below, it might be helpful to document this change, which was introduced in #16454.
Fixes: #16778
Checklist
Affected core subsystem(s)
doc