Skip to content

test: refactor test-child-process-pass-fd - #17596

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:refactor-cp-test
Closed

test: refactor test-child-process-pass-fd#17596
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:refactor-cp-test

Conversation

@Trott

@TrottTrott commented Dec 10, 2017

Copy link
Copy Markdown
Member

Add a comment explaining the test (especailly why it forks 80 processes.
Use destructuring and an arrow function callback.

Ping @santigimeno (who wrote the test)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test child_process

@Trott
test: refactor test-child-process-pass-fd
ea5c1e8
Add a comment explaining the test (especailly why it forks 80 processes.
Use destructuring and an arrow function callback.
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 10, 2017
XadillaX
XadillaX approved these changes Dec 11, 2017
View reviewed changes

@XadillaXXadillaX left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@Trott

Trott commented Dec 11, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/12046/

Trott added a commit to Trott/io.js that referenced this pull request Dec 12, 2017
@Trott
test: refactor test-child-process-pass-fd
ac25cee
Add a comment explaining the test (especailly why it forks 80 processes.
Use destructuring and an arrow function callback.
PR-URL: nodejs#17596
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@Trott

Trott commented Dec 12, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in ac25cee

@TrottTrott closed this Dec 12, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott@MylesBorins
test: refactor test-child-process-pass-fd
f814321
Add a comment explaining the test (especailly why it forks 80 processes.
Use destructuring and an arrow function callback.
PR-URL: #17596
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott@MylesBorins
test: refactor test-child-process-pass-fd
e7ae8eb
Add a comment explaining the test (especailly why it forks 80 processes.
Use destructuring and an arrow function callback.
PR-URL: #17596
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@MylesBorinsMylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott@gibfahn
test: refactor test-child-process-pass-fd
c7891c4
Add a comment explaining the test (especailly why it forks 80 processes.
Use destructuring and an arrow function callback.
PR-URL: #17596
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott@gibfahn
test: refactor test-child-process-pass-fd
dbf5ddb
Add a comment explaining the test (especailly why it forks 80 processes.
Use destructuring and an arrow function callback.
PR-URL: #17596
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott@gibfahn
test: refactor test-child-process-pass-fd
c0b2fe5
Add a comment explaining the test (especailly why it forks 80 processes.
Use destructuring and an arrow function callback.
PR-URL: #17596
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@gibfahngibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorinsMylesBorins mentioned this pull request Dec 20, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott@gibfahn
test: refactor test-child-process-pass-fd
c02ac84
Add a comment explaining the test (especailly why it forks 80 processes.
Use destructuring and an arrow function callback.
PR-URL: #17596
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
@Trott
Trott deleted the refactor-cp-test branch January 13, 2022 22:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@JungMinuJungMinuJungMinu approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@XadillaXXadillaXXadillaX approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@cjihrig@XadillaX@JungMinu@BridgeAR@gibfahn@nodejs-github-bot