Skip to content

src: update trace event macros to v8 6.3 version - #17640

Closed
kjin wants to merge 2 commits into
nodejs:masterfrom
kjin:trace-event-6.3
Closed

src: update trace event macros to v8 6.3 version#17640
kjin wants to merge 2 commits into
nodejs:masterfrom
kjin:trace-event-6.3

Conversation

@kjin

@kjinkjin commented Dec 13, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, tracing

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. labels Dec 13, 2017
@kjin

kjin commented Dec 13, 2017

Copy link
Copy Markdown
ContributorAuthor

cc @ofrobots

@addaleax

addaleax commented Dec 13, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/14786/

@jasnell

jasnell commented Dec 13, 2017

Copy link
Copy Markdown
Member

Out of curiosity, does this give us support for the WITH_TIMESTAMP macros now?

@BridgeAR

BridgeAR commented Dec 13, 2017

Copy link
Copy Markdown
Member

I mark it as ready but I think it should probably wait the full 48 hours.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
@kjin

kjin commented Dec 13, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@jasnell I made a mistake here, TIMESTAMP macros are not implemented in v8 yet. I'm checking to see what the status of this is... will provide an update. @BridgeAR can you remove the ready label?

@BridgeARBridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
@ofrobots

ofrobots commented Dec 13, 2017

Copy link
Copy Markdown
Contributor

I think this PR re-syncs the trace-event implementation with what we have in V8. WITH_TIMESTAMP is not implemented in V8 just yet. Chromium does have it, but it depends on the base C++ headers and atomics that are available in Chromium but not in V8. I can take a look at how to implement WITH_TIMESTAMP as a follow-on – whether they need to be in V8 (and re-synced here) or whether we can add them to Node directly.

@jasnell

jasnell commented Dec 14, 2017

Copy link
Copy Markdown
Member

No worries and no rush. Was just curious. 😎

mhdawson
mhdawson approved these changes Jan 3, 2018
View reviewed changes

@mhdawsonmhdawson left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming CI is green.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 19, 2018
@BridgeAR

BridgeAR commented Jan 19, 2018

Copy link
Copy Markdown
Member

New CI https://ci.nodejs.org/job/node-test-pull-request/12625/

@maclover7
maclover7force-pushed the master branch 2 times, most recently from bb5575a to 993b716CompareJanuary 26, 2018 22:02
@BridgeAR

BridgeAR commented Jan 31, 2018

Copy link
Copy Markdown
Member

New CI again https://ci.nodejs.org/job/node-test-pull-request/12834/

@BridgeAR

BridgeAR commented Feb 1, 2018

Copy link
Copy Markdown
Member

CI is super red: see e.g. https://ci.nodejs.org/job/node-test-commit-freebsd/15082/nodes=freebsd11-x64/console

@kjin would you please have a look at it?

@BridgeARBridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 1, 2018
@BridgeAR

BridgeAR commented Feb 7, 2018

Copy link
Copy Markdown
Member

Ping @kjin

@kjin

kjin commented Feb 13, 2018

Copy link
Copy Markdown
ContributorAuthor

@BridgeAR Fixed, sorry about the delay!

@ofrobots

ofrobots commented Feb 13, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/13156/

@jasnell

jasnell commented Feb 14, 2018

Copy link
Copy Markdown
Member

Several errors in CI, none appear to be related.

Rerunning CI on SmartOS just to be safe: https://ci.nodejs.org/job/node-test-commit-smartos/15393/

jasnell pushed a commit that referenced this pull request Feb 14, 2018
@kjin@jasnell
src: update trace event macros to v8 6.4 version
d8ec49e
PR-URL: #17640
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell

jasnell commented Feb 14, 2018

Copy link
Copy Markdown
Member

Landed in d8ec49e

@jasnelljasnell closed this Feb 14, 2018
@targostargos mentioned this pull request Apr 2, 2018
Closed
4 tasks
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@kjin@MayaLekova
src: update trace event macros to v8 6.4 version
4f0f789
PR-URL: nodejs#17640
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.trace_eventsIssues and PRs related to V8, Node.js core, and userspace code trace events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@kjin@addaleax@jasnell@BridgeAR@ofrobots@cjihrig@mhdawson@MylesBorins@nodejs-github-bot