Uh oh!
There was an error while loading. Please reload this page.
doc: edit CONTRIBUTING.md preamble - #17700
Closed
Trott wants to merge 1 commit into
Closed
Conversation
gireeshpunathil
approved these changes
Dec 15, 2017
richardlau
approved these changes
Dec 15, 2017
maclover7
approved these changes
Dec 15, 2017
maclover7
commented
Dec 15, 2017
Contributor
addaleax
approved these changes
Dec 15, 2017
Trott
commented
Dec 16, 2017
MemberAuthor
Re-running LinuxONE: https://ci.nodejs.org/job/node-test-commit-linuxone/11232/ |
lpinca
approved these changes
Dec 16, 2017
gibfahn
approved these changes
Dec 16, 2017
gibfahn
reviewed
Dec 16, 2017
Member
There was a problem hiding this comment.
Maybe just at each step., not sure the process needs to be repeated here.
Fishrock123
approved these changes
Dec 17, 2017
Fishrock123
left a comment
Contributor
There was a problem hiding this comment.
lgtm with Gibson's comment
Make the preamble to CONTRIBUTING.md more concise and focused.
Trottforce-pushed
the
shorter-contributing
branch
from
December 17, 2017 17:24
9ae768d to
ffe8503Comparejasnell
approved these changes
Dec 18, 2017
Trott
commented
Dec 18, 2017
MemberAuthor
Landed in 90abfd6 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Dec 18, 2017
Make the preamble to CONTRIBUTING.md more concise and focused. PR-URL: nodejs#17700 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 8, 2018
Make the preamble to CONTRIBUTING.md more concise and focused. PR-URL: #17700 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 9, 2018
Make the preamble to CONTRIBUTING.md more concise and focused. PR-URL: #17700 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Jan 23, 2018
Make the preamble to CONTRIBUTING.md more concise and focused. PR-URL: #17700 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit
that referenced
this pull request
Jan 24, 2018
Make the preamble to CONTRIBUTING.md more concise and focused. PR-URL: #17700 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the preamble to CONTRIBUTING.md more concise and focused.
Checklist
Affected core subsystem(s)
doc