Skip to content

test: fix unreliable async-hooks/test-signalwrap - #17827

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-signalwrap
Closed

test: fix unreliable async-hooks/test-signalwrap#17827
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-signalwrap

Conversation

@Trott

@TrottTrott commented Dec 22, 2017

Copy link
Copy Markdown
Member

Use an interval to keep the event loop open so the test does not exit
before receiving all signals fom asynchronous exec() calls.

Fixes: #14070

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test async_hooks

@Trott
test: fix unreliable async-hooks/test-signalwrap
a332b74
Use an interval to keep the event loop open so the test does not exit
before receiving all signals fom asynchronous `exec()` calls.
Fixes: nodejs#14070
@TrottTrott added async_hooks Issues and PRs related to the async hooks subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests. labels Dec 22, 2017
@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Dec 22, 2017
@TrottTrott mentioned this pull request Dec 22, 2017
Closed
@Trott

Trott commented Dec 22, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/12267/

@Trott

Trott commented Dec 22, 2017

Copy link
Copy Markdown
MemberAuthor

Stress test showing failures on master: https://ci.nodejs.org/job/node-stress-single-test/1571/nodes=alpine34-container-x64/console

Stress test with same parameters but on this PR (hopefully showing no failures when it finishes): https://ci.nodejs.org/job/node-stress-single-test/1573/nodes=alpine34-container-x64/console

@Trott

Trott commented Dec 22, 2017

Copy link
Copy Markdown
MemberAuthor

CI is green, stress test for master is red, stress test for this PR is green. 🎉

@maclover7maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 24, 2017
Trott added a commit to Trott/io.js that referenced this pull request Dec 25, 2017
@Trott
test: fix unreliable async-hooks/test-signalwrap
457ceeb
Use an interval to keep the event loop open so the test does not exit
before receiving all signals fom asynchronous `exec()` calls.
PR-URL: nodejs#17827Fixes: nodejs#14070
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@Trott

Trott commented Dec 25, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in 457ceeb

@TrottTrott closed this Dec 25, 2017
@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 29, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Trott@MylesBorins
test: fix unreliable async-hooks/test-signalwrap
e297f2e
Use an interval to keep the event loop open so the test does not exit
before receiving all signals fom asynchronous `exec()` calls.
PR-URL: #17827Fixes: #14070
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott@MylesBorins
test: fix unreliable async-hooks/test-signalwrap
2522a28
Use an interval to keep the event loop open so the test does not exit
before receiving all signals fom asynchronous `exec()` calls.
PR-URL: #17827Fixes: #14070
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott@MylesBorins
test: fix unreliable async-hooks/test-signalwrap
ee4cbac
Use an interval to keep the event loop open so the test does not exit
before receiving all signals fom asynchronous `exec()` calls.
PR-URL: #17827Fixes: #14070
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 22, 2018
@Trott@MylesBorins
test: fix unreliable async-hooks/test-signalwrap
3aefc25
Use an interval to keep the event loop open so the test does not exit
before receiving all signals fom asynchronous `exec()` calls.
PR-URL: #17827Fixes: #14070
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 14, 2018
@Trott@MylesBorins
test: fix unreliable async-hooks/test-signalwrap
38e4dd1
Use an interval to keep the event loop open so the test does not exit
before receiving all signals fom asynchronous `exec()` calls.
PR-URL: #17827Fixes: #14070
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jul 9, 2018
Merged
rvagg pushed a commit that referenced this pull request Aug 16, 2018
@Trott@rvagg
test: fix unreliable async-hooks/test-signalwrap
7d263ff
Use an interval to keep the event loop open so the test does not exit
before receiving all signals fom asynchronous `exec()` calls.
PR-URL: #17827Fixes: #14070
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@Trott
Trott deleted the fix-signalwrap branch January 13, 2022 22:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

async_hooksIssues and PRs related to the async hooks subsystem.flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: investigate async-hooks/test-signalwrap

8 participants

@Trott@cjihrig@gibfahn@MylesBorins@AndreasMadsen@addaleax@maclover7@nodejs-github-bot