Skip to content

[backport v6.x] promises: more robust stringification - #17833

Closed
TimothyGu wants to merge 1 commit into
nodejs:v6.x-stagingfrom
TimothyGu:v6.x-promises
Closed

[backport v6.x] promises: more robust stringification#17833
TimothyGu wants to merge 1 commit into
nodejs:v6.x-stagingfrom
TimothyGu:v6.x-promises

Conversation

@TimothyGu

@TimothyGuTimothyGu commented Dec 23, 2017

Copy link
Copy Markdown
Member

PR-URL: #13784
Fixes: #13771
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Rod Vagg rod@vagg.org
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

promises

@TimothyGu
promises: more robust stringification
83261d2
PR-URL: nodejs#13784Fixes: nodejs#13771
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TimothyGuTimothyGu added process Issues and PRs related to the process subsystem. promises Issues and PRs related to ECMAScript promises. v6.x labels Dec 23, 2017
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. util Issues and PRs related to the built-in util module. v6.x labels Dec 23, 2017
@TimothyGuTimothyGu mentioned this pull request Dec 23, 2017
Closed
3 tasks
@TimothyGu

TimothyGu commented Dec 23, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/12274/

@MylesBorins

MylesBorins commented Jan 17, 2018

Copy link
Copy Markdown
Contributor

ci: https://ci.nodejs.org/job/node-test-pull-request/12576/

@MylesBorins

MylesBorins commented Jan 18, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/12599/

MylesBorins pushed a commit that referenced this pull request Jan 18, 2018
@TimothyGu@MylesBorins
promises: more robust stringification
3e7f0fc
Backport-PR-URL: #17833
PR-URL: #13784Fixes: #13771
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

MylesBorins commented Jan 18, 2018

Copy link
Copy Markdown
Contributor

arm failure is flake, landed in 3e7f0fc

@TimothyGu
TimothyGu deleted the v6.x-promises branch January 20, 2018 04:57
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@TimothyGu@MylesBorins
promises: more robust stringification
a5ecc23
Backport-PR-URL: #17833
PR-URL: #13784Fixes: #13771
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@TimothyGu@MylesBorins
promises: more robust stringification
2d6e802
Backport-PR-URL: #17833
PR-URL: #13784Fixes: #13771
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@TimothyGu@MylesBorins
promises: more robust stringification
c64a73b
Backport-PR-URL: #17833
PR-URL: #13784Fixes: #13771
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MylesBorinsMylesBorinsAwaiting requested review from MylesBorins

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.processIssues and PRs related to the process subsystem.promisesIssues and PRs related to ECMAScript promises.utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TimothyGu@MylesBorins@nodejs-github-bot