Skip to content

doc: improve security section of README.md - #17929

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-security-paragraph
Closed

doc: improve security section of README.md#17929
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-security-paragraph

Conversation

@Trott

@TrottTrott commented Jan 1, 2018•
edited
Loading

Copy link
Copy Markdown
Member
  • Remove fluff text and get to the point: Report security flaws to
    security@nodejs.org. Please do not disclose security flaws publicly
    until they have been handled by the security team.
  • Fix somewhat confusing paragraph that says there are no "hard
    and fast rules" but then uses must in the context of a "general
    rule". Easiest solution seems to be to change must to should.
  • Minor style change (you will instead of you'll)
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@TrottTrott added the doc Issues and PRs related to the documentations. label Jan 1, 2018
@Trott
doc: improve security section of README.md
a123cdd
* Remove fluff text and get to the point: Report security flaws to
security@nodejs.org. Please do not disclose security flaws publicly
until they have been handled by the seucrity team.
* Fix somewhat confusing paragraph that says there are no "hard
and fast rules" but then uses _must_ in the context of a "general
rule". Easiest solution seems to be to change _must_ to _should_.
* Minor style change (_you will_ instead of _you'll_)
@Trott
Trottforce-pushed the fix-security-paragraph branch from de4f20f to a123cddCompareJanuary 1, 2018 05:02
@maclover7

maclover7 commented Jan 1, 2018

Copy link
Copy Markdown
Contributor

Docs CI: https://ci.nodejs.org/job/node-test-pull-request-lite/63/

@maclover7maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 2, 2018
mhdawson
mhdawson approved these changes Jan 3, 2018
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott

Trott commented Jan 4, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in c3e75ae

@TrottTrott closed this Jan 4, 2018
Trott added a commit to Trott/io.js that referenced this pull request Jan 4, 2018
@Trott
doc: improve security section of README.md
c3e75ae
* Remove fluff text and get to the point: Report security flaws to
security@nodejs.org. Please do not disclose security flaws publicly
until they have been handled by the security team.
* Fix somewhat confusing paragraph that says there are no "hard
and fast rules" but then uses _must_ in the context of a "general
rule". Easiest solution seems to be to change _must_ to _should_.
* Minor style change (_you will_ instead of _you'll_)
PR-URL: nodejs#17929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Trott@MylesBorins
doc: improve security section of README.md
9197217
* Remove fluff text and get to the point: Report security flaws to
security@nodejs.org. Please do not disclose security flaws publicly
until they have been handled by the security team.
* Fix somewhat confusing paragraph that says there are no "hard
and fast rules" but then uses _must_ in the context of a "general
rule". Easiest solution seems to be to change _must_ to _should_.
* Minor style change (_you will_ instead of _you'll_)
PR-URL: #17929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott@MylesBorins
doc: improve security section of README.md
c02559e
* Remove fluff text and get to the point: Report security flaws to
security@nodejs.org. Please do not disclose security flaws publicly
until they have been handled by the security team.
* Fix somewhat confusing paragraph that says there are no "hard
and fast rules" but then uses _must_ in the context of a "general
rule". Easiest solution seems to be to change _must_ to _should_.
* Minor style change (_you will_ instead of _you'll_)
PR-URL: #17929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott@MylesBorins
doc: improve security section of README.md
294c5f4
* Remove fluff text and get to the point: Report security flaws to
security@nodejs.org. Please do not disclose security flaws publicly
until they have been handled by the security team.
* Fix somewhat confusing paragraph that says there are no "hard
and fast rules" but then uses _must_ in the context of a "general
rule". Easiest solution seems to be to change _must_ to _should_.
* Minor style change (_you will_ instead of _you'll_)
PR-URL: #17929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 10, 2018
Merged
@TimothyGuTimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@Trott@MylesBorins
doc: improve security section of README.md
135bc61
* Remove fluff text and get to the point: Report security flaws to
security@nodejs.org. Please do not disclose security flaws publicly
until they have been handled by the security team.
* Fix somewhat confusing paragraph that says there are no "hard
and fast rules" but then uses _must_ in the context of a "general
rule". Easiest solution seems to be to change _must_ to _should_.
* Minor style change (_you will_ instead of _you'll_)
PR-URL: #17929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@Trott@MylesBorins
doc: improve security section of README.md
a79d825
* Remove fluff text and get to the point: Report security flaws to
security@nodejs.org. Please do not disclose security flaws publicly
until they have been handled by the security team.
* Fix somewhat confusing paragraph that says there are no "hard
and fast rules" but then uses _must_ in the context of a "general
rule". Easiest solution seems to be to change _must_ to _should_.
* Minor style change (_you will_ instead of _you'll_)
PR-URL: #17929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2018
Merged
@ChALkeRChALkeR added the security Issues and PRs related to security. label Jan 28, 2018
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@Trott@MylesBorins
doc: improve security section of README.md
9fed327
* Remove fluff text and get to the point: Report security flaws to
security@nodejs.org. Please do not disclose security flaws publicly
until they have been handled by the security team.
* Fix somewhat confusing paragraph that says there are no "hard
and fast rules" but then uses _must_ in the context of a "general
rule". Easiest solution seems to be to change _must_ to _should_.
* Minor style change (_you will_ instead of _you'll_)
PR-URL: #17929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@Trott@MylesBorins
doc: improve security section of README.md
d9307fe
* Remove fluff text and get to the point: Report security flaws to
security@nodejs.org. Please do not disclose security flaws publicly
until they have been handled by the security team.
* Fix somewhat confusing paragraph that says there are no "hard
and fast rules" but then uses _must_ in the context of a "general
rule". Easiest solution seems to be to change _must_ to _should_.
* Minor style change (_you will_ instead of _you'll_)
PR-URL: #17929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@Trott@MylesBorins
doc: improve security section of README.md
12db4d9
* Remove fluff text and get to the point: Report security flaws to
security@nodejs.org. Please do not disclose security flaws publicly
until they have been handled by the security team.
* Fix somewhat confusing paragraph that says there are no "hard
and fast rules" but then uses _must_ in the context of a "general
rule". Easiest solution seems to be to change _must_ to _should_.
* Minor style change (_you will_ instead of _you'll_)
PR-URL: #17929
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Trott
Trott deleted the fix-security-paragraph branch January 13, 2022 22:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+4 more reviewers
@TimothyGuTimothyGuTimothyGu approved these changes
@maclover7maclover7maclover7 approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.securityIssues and PRs related to security.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Trott@maclover7@jasnell@lpinca@TimothyGu@cjihrig@mhdawson@gibfahn@ChALkeR@MylesBorins