Skip to content

doc: move joshgav to TSC emeriti list - #17953

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:joshgav-emeritus
Closed

doc: move joshgav to TSC emeriti list#17953
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:joshgav-emeritus

Conversation

@Trott

@TrottTrott commented Jan 2, 2018

Copy link
Copy Markdown
Member

Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@Trott
doc: move joshgav to TSC emeriti list
7bf006f
Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.
@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 2, 2018
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 2, 2018
@Trott

Trott commented Jan 2, 2018

Copy link
Copy Markdown
MemberAuthor

@nodejs/tsc

MylesBorins
MylesBorins approved these changes Jan 2, 2018
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins

MylesBorins commented Jan 2, 2018

Copy link
Copy Markdown
Contributor

This will also need to be updated in https://github.com/nodejs/TSC

sidebar: does it make sense for the list to only exist in one location?

@targos

targos commented Jan 2, 2018

Copy link
Copy Markdown
Member

@MylesBorins yes!

@Trott

Trott commented Jan 2, 2018

Copy link
Copy Markdown
MemberAuthor

@MylesBorins Already updated there via PR from Josh himself. On reducing the duplication, yes please, and I think the way to do it is to remove the list from the TSC repo and replace it with a link to the list in this doc.

mcollina
mcollina approved these changes Jan 3, 2018
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maclover7maclover7 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 3, 2018
@maclover7

maclover7 commented Jan 3, 2018

Copy link
Copy Markdown
Contributor

Docs CI: https://ci.nodejs.org/job/node-test-pull-request-lite/70/

mhdawson
mhdawson approved these changes Jan 3, 2018
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott

Trott commented Jan 4, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 3f2382b

Trott added a commit to Trott/io.js that referenced this pull request Jan 4, 2018
@Trott
doc: move joshgav to TSC emeriti list
3f2382b
Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.
PR-URL: nodejs#17953
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@TrottTrott closed this Jan 4, 2018
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@Trott@MylesBorins
doc: move joshgav to TSC emeriti list
a1e414e
Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.
PR-URL: #17953
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott@MylesBorins
doc: move joshgav to TSC emeriti list
2214669
Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.
PR-URL: #17953
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@Trott@MylesBorins
doc: move joshgav to TSC emeriti list
6efef47
Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.
PR-URL: #17953
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 10, 2018
Merged
@TimothyGuTimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@Trott@MylesBorins
doc: move joshgav to TSC emeriti list
e734e0a
Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.
PR-URL: #17953
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@Trott@MylesBorins
doc: move joshgav to TSC emeriti list
1622547
Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.
PR-URL: #17953
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@Trott@MylesBorins
doc: move joshgav to TSC emeriti list
36868c2
Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.
PR-URL: #17953
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@Trott@MylesBorins
doc: move joshgav to TSC emeriti list
791b6bb
Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.
PR-URL: #17953
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@Trott@MylesBorins
doc: move joshgav to TSC emeriti list
15d0ed5
Josh is focusing on other technologies these days and has moved to the
TSC Emeritus role. He already opened a pull request in the TSC
repository to make this change. This makes the same change in the main
repository.
PR-URL: #17953
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@Trott
Trott deleted the joshgav-emeritus branch January 13, 2022 22:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+4 more reviewers
@ofrobotsofrobotsofrobots approved these changes
@MylesBorinsMylesBorinsMylesBorins approved these changes
@evanlucasevanlucasevanlucas approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

14 participants

@Trott@MylesBorins@targos@maclover7@mcollina@ofrobots@evanlucas@lpinca@cjihrig@joyeecheung@gireeshpunathil@mhdawson@TimothyGu@nodejs-github-bot