Skip to content

benchmark: fix timeout bug in write-stream-throughput - #17958

Closed
apapirovski wants to merge 1 commit into
nodejs:masterfrom
apapirovski:fix-benchmark-write-stream-throughput
Closed

benchmark: fix timeout bug in write-stream-throughput#17958
apapirovski wants to merge 1 commit into
nodejs:masterfrom
apapirovski:fix-benchmark-write-stream-throughput

Conversation

@apapirovski

@apapirovskiapapirovski commented Jan 3, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Currently it's possible for this benchmark to call bench.end() before bench.start(). Fix this to resolve some occasional CI flakiness.

Fixes: #17901

CI: https://ci.nodejs.org/job/node-test-pull-request/12388/
Stress test CI: https://ci.nodejs.org/job/node-stress-single-test/1600/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

@nodejs-github-botnodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. fs Issues and PRs related to the fs subsystem / file system. labels Jan 3, 2018
@apapirovskiapapirovski added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 3, 2018
@TrottTrott mentioned this pull request Jan 4, 2018
Closed
4 tasks
@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 4, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 5, 2018
@apapirovski@BridgeAR
benchmark: fix timeout in write-stream-throughput
b43a496
PR-URL: nodejs#17958Fixes: nodejs#17901
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

BridgeAR commented Jan 5, 2018

Copy link
Copy Markdown
Member

Landed in b43a496

@BridgeARBridgeAR closed this Jan 5, 2018
@apapirovski
apapirovski deleted the fix-benchmark-write-stream-throughput branch January 5, 2018 02:24
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@apapirovski@MylesBorins
benchmark: fix timeout in write-stream-throughput
ae76f24
PR-URL: #17958Fixes: #17901
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@apapirovski@MylesBorins
benchmark: fix timeout in write-stream-throughput
07fcb77
PR-URL: #17958Fixes: #17901
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
@apapirovski@MylesBorins
benchmark: fix timeout in write-stream-throughput
63c23a1
PR-URL: #17958Fixes: #17901
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorinsMylesBorins mentioned this pull request Jan 10, 2018
Merged
@TimothyGuTimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@apapirovski@MylesBorins
benchmark: fix timeout in write-stream-throughput
452d2c5
PR-URL: #17958Fixes: #17901
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@apapirovski@MylesBorins
benchmark: fix timeout in write-stream-throughput
1c55ae5
PR-URL: #17958Fixes: #17901
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@apapirovski@MylesBorins
benchmark: fix timeout in write-stream-throughput
31fbd88
PR-URL: #17958Fixes: #17901
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@apapirovski@MylesBorins
benchmark: fix timeout in write-stream-throughput
b71c29c
PR-URL: #17958Fixes: #17901
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@apapirovski@MylesBorins
benchmark: fix timeout in write-stream-throughput
6f33953
PR-URL: #17958Fixes: #17901
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.fast-trackPRs that do not need to wait for 48 hours to land.fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

benchmark/fs/write-stream-throughput.js can call bench.end() without calling bench.start()

9 participants

@apapirovski@BridgeAR@jasnell@lpinca@cjihrig@joyeecheung@MylesBorins@TimothyGu@nodejs-github-bot