Uh oh!
There was an error while loading. Please reload this page.
build: put .PHONY on line before of its target definition. - #17964
Closed
oantoro wants to merge 1 commit into
Closed
build: put .PHONY on line before of its target definition.#17964oantoro wants to merge 1 commit into
oantoro wants to merge 1 commit into
Conversation
Before this change, the .PHONY is followed by multiple targets. Now it is multiple .PHONY for each target Refs: nodejs#16968
oantoro
commented
Jan 4, 2018
Author
@bnoordhuis could you review this PR? Thank you |
joyeecheung
approved these changes
Jan 4, 2018
joyeecheung
commented
Jan 4, 2018
Member
BridgeAR
approved these changes
Jan 4, 2018
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 5, 2018
Before this change, the .PHONY is followed by multiple targets. Now it is multiple .PHONY for each target. PR-URL: nodejs#17964 Refs: nodejs#16968 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
commented
Jan 5, 2018
Member
Landed in feaf6ac I fixed the commit message while landing. |
Merged
MylesBorins
commented
Jan 24, 2018
Contributor
Should this be backported to LTS? if so it will need a backport |
This comment has been minimized.
This comment has been minimized.
MylesBorins
commented
May 22, 2018
Contributor
ping @nodejs/build re: backport |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the .PHONY is followed by multiple targets. Now it is multiple .PHONY for each target
Refs: #16968
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build