Skip to content

Do not override V8's gitignore - #18010

Closed
hashseed wants to merge 1 commit into
nodejs:masterfrom
hashseed:gitignore
Closed

Do not override V8's gitignore#18010
hashseed wants to merge 1 commit into
nodejs:masterfrom
hashseed:gitignore

Conversation

@hashseed

@hashseedhashseed commented Jan 5, 2018•
edited
Loading

Copy link
Copy Markdown
Member

The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@hashseed
Do not override V8's gitignore
77e3640
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 5, 2018
addaleax
addaleax approved these changes Jan 5, 2018
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, I think you could additionally prefix node and similar entries with ./ so that they don’t inadvertently get ignored in other subdirectories as well

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 6, 2018
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 6, 2018
hashseed added a commit that referenced this pull request Jan 9, 2018
@hashseed
tools: do not override V8's gitignore
5a1aeab
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
PR-URL: #18010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@hashseed

hashseed commented Jan 9, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Landed in 5a1aeab. Closing.

@hashseedhashseed closed this Jan 9, 2018
@cjihrig

cjihrig commented Jan 9, 2018

Copy link
Copy Markdown
Contributor

It looks like this may have landed without a CI run.

@hashseed

hashseed commented Jan 9, 2018

Copy link
Copy Markdown
MemberAuthor

@cjihrig I realized that. But then I thought that a .gitignore change would hardly have any affect on test results.

MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@hashseed@MylesBorins
tools: do not override V8's gitignore
371b230
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
PR-URL: #18010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorinsMylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 10, 2018
@hashseed@MylesBorins
tools: do not override V8's gitignore
4dacff7
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
PR-URL: #18010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@hashseed
hashseed deleted the gitignore branch January 11, 2018 06:57
hashseed added a commit to v8/node that referenced this pull request Jan 11, 2018
@hashseed
tools: do not override V8's gitignore
60bf980
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
PR-URL: nodejs#18010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@TimothyGuTimothyGu removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 13, 2018
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@hashseed@MylesBorins
tools: do not override V8's gitignore
ab2a207
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
PR-URL: #18010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
@hashseed@MylesBorins
tools: do not override V8's gitignore
8250a5a
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
PR-URL: #18010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@hashseed@MylesBorins
tools: do not override V8's gitignore
b121279
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
PR-URL: #18010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@hashseed@MylesBorins
tools: do not override V8's gitignore
b13cb7e
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
PR-URL: #18010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@hashseed@MylesBorins
tools: do not override V8's gitignore
51bfd32
The root .gitignore contains "node", which causes all of
deps/v8/tools/node to be ignored. That is somewhat inconvenient when
updating V8.
PR-URL: #18010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@hashseed@cjihrig@jasnell@addaleax@tniessen@BridgeAR@MylesBorins@Trott@TimothyGu@BethGriggs@nodejs-github-bot