Skip to content

lib,test: fix spelling in comments - #18018

Closed
tniessen wants to merge 3 commits into
nodejs:masterfrom
tniessen:fix-spelling-in-tests
Closed

lib,test: fix spelling in comments#18018
tniessen wants to merge 3 commits into
nodejs:masterfrom
tniessen:fix-spelling-in-tests

Conversation

@tniessen

@tniessentniessen commented Jan 6, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Various spelling fixes. I am not sure whether to split this into multiple commits.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

lib, test

@nodejs-github-botnodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Jan 6, 2018
maclover7
maclover7 approved these changes Jan 6, 2018
View reviewed changes

@maclover7maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Personally, I'm fine with one large commit.

@tniessentniessen changed the title test: fix spelling in test case commentslib,test: fix spelling in test case commentsJan 6, 2018
@tniessentniessen changed the title lib,test: fix spelling in test case commentslib,test: fix spelling in commentsJan 6, 2018
apapirovski
apapirovski approved these changes Jan 6, 2018
View reviewed changes

@apapirovskiapapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! 👍

Comment threadtest/parallel/test-http-agent-keepalive.js Outdated

@apapirovskiapapirovskiJan 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "remove" here is supposed to be "remote"?

@tniessentniessenJan 6, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh yeah sure, thanks!

Comment threadtest/parallel/test-http-extra-response.js Outdated

@apapirovskiapapirovskiJan 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this comment adds much in general, to be honest. I would be in favour of taking it out.

Comment threadtest/parallel/test-promises-unhandled-rejections.js Outdated

@apapirovskiapapirovskiJan 6, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what this comment is saying (before or after). :( I think the tests describe what they do well enough.

(If we are to keep it, I would prefer to use the more common version "adaptation".)

@tniessentniessenJan 6, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand that test either, I went with "adaptation" for now. If someone knows what's going on here, we might actually remove it.

@tniessen

tniessen commented Jan 6, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/12438/

@tniessen
tniessenforce-pushed the fix-spelling-in-tests branch from d984a90 to 8fcc84dCompareJanuary 7, 2018 15:03
@jasnell

jasnell commented Jan 9, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/12472/

@tniessen

tniessen commented Jan 10, 2018

Copy link
Copy Markdown
MemberAuthor

Seems like CI was interrupted, new CI: https://ci.nodejs.org/job/node-test-pull-request/12494/

tniessen added a commit that referenced this pull request Jan 11, 2018
@tniessen
test: fix spelling in test case comments
e890344
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
tniessen added a commit that referenced this pull request Jan 11, 2018
@tniessen
lib: fix spelling in comments
ba07699
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@tniessen

tniessen commented Jan 11, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in e890344, ba07699.

@AndreasMadsenAndreasMadsen removed the async_hooks Issues and PRs related to the async hooks subsystem. label Jan 16, 2018
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@tniessen@evanlucas
test: fix spelling in test case comments
5fccb6e
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@tniessen@evanlucas
lib: fix spelling in comments
dcdb646
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@evanlucasevanlucas mentioned this pull request Jan 30, 2018
Merged
@MylesBorins

MylesBorins commented Feb 27, 2018

Copy link
Copy Markdown
Contributor

Should this be backported to v6.x-staging or v8.x-staging?? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

tniessen added a commit to tniessen/node that referenced this pull request Mar 4, 2018
@tniessen
test: fix spelling in test case comments
dbf0618
PR-URL: nodejs#18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
tniessen added a commit to tniessen/node that referenced this pull request Mar 4, 2018
@tniessen
lib: fix spelling in comments
e335b55
PR-URL: nodejs#18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@tniessentniessen mentioned this pull request Mar 4, 2018
Closed
tniessen added a commit to tniessen/node that referenced this pull request Mar 4, 2018
@tniessen
test: fix spelling in test case comments
8a95359
PR-URL: nodejs#18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@tniessentniessen mentioned this pull request Mar 4, 2018
Closed
MylesBorins pushed a commit that referenced this pull request Mar 14, 2018
@tniessen@MylesBorins
test: fix spelling in test case comments
894b179
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@tniessen@MylesBorins
test: fix spelling in test case comments
a52f4eb
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@tniessen@MylesBorins
lib: fix spelling in comments
8cbb164
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@tniessen@MylesBorins
test: fix spelling in test case comments
1196355
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@tniessen@MylesBorins
test: fix spelling in test case comments
059a803
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@tniessen@MylesBorins
lib: fix spelling in comments
63b0de2
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@tniessen@MylesBorins
test: fix spelling in test case comments
502781c
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@tniessen@MylesBorins
test: fix spelling in test case comments
1043b6f
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@tniessen@MylesBorins
lib: fix spelling in comments
3df0570
Backport-PR-URL: #19118
PR-URL: #18018
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 13, 2018
Merged
@MylesBorinsMylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+4 more reviewers
@apapirovskiapapirovskiapapirovski approved these changes
@maclover7maclover7maclover7 approved these changes
@hiroppyhiroppyhiroppy approved these changes
@starkwangstarkwangstarkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@tniessen@jasnell@MylesBorins@apapirovski@lpinca@cjihrig@maclover7@hiroppy@starkwang@AndreasMadsen@nodejs-github-bot