src: add getopt option parser by evanlucas · Pull Request #1804 · nodejs/node

evanlucas · 2015-05-26T23:06:42Z

Initial getopt implementation for option parsing. Supersedes #1726.

I split out the actual options to try and make it more maintainable.

mscdex · 2015-05-27T00:43:06Z

It would be nice if we could generate the help text from the defined options. That would help avoid duplication.

evanlucas · 2015-05-27T00:46:21Z

I think that's definitely doable. I'll see if I can add that tonight.

evanlucas · 2015-05-27T05:34:04Z

Ok, help is automatically generated now too :]

bnoordhuis · 2015-05-27T10:43:02Z

I suggest you remove this code. I don't think many people would expect POSIXLY_CORRECT to affect the iojs binary.

evanlucas · 2015-05-28T22:43:57Z

Switched to use a global variable node_options

bnoordhuis · 2015-05-29T12:15:42Z

For the love of $DEITY, please don't make this public.

bnoordhuis · 2015-05-29T12:28:28Z

It's probably a good idea to add some option parsing regression tests.

evanlucas · 2015-05-29T14:52:51Z

Ok, made requested changes and added tests for options that are not currently being tested

bnoordhuis · 2015-05-29T15:03:31Z

This is not 100% sound, the output can get split over multiple chunks. Can I suggest you use spawnSync instead?
EDIT: Or execFile, like you do below.

sure, will update that now. Want me to do that on all of these tests?

Yes, please.

bnoordhuis · 2015-05-29T15:07:50Z

LGTM with nits and assuming the CI is happy.

evanlucas · 2015-05-29T15:32:39Z

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/725/

evanlucas · 2015-05-29T18:01:10Z

Ok, working on SmartOS support right now. Will run another CI once I get that done.

evanlucas · 2015-05-30T18:05:56Z

Ok, final CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/736/

Last one had failures related to #1837.

evanlucas · 2015-06-01T12:42:36Z

Does this need to wait until 3.0?

bnoordhuis · 2015-06-01T13:10:50Z

If there are no user-visible changes, it can go into a patch release.

evanlucas · 2015-06-01T13:24:12Z

The actual help message that is printed is slightly different since it is automatically generated based on the options.

Options have been moved into the NodeOptions class. A new global, node_options now exists and is used to access the options after the command line arguments have been parsed. PR-URL: nodejs#1804 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

evanlucas · 2015-06-01T13:43:41Z

Landed in c0e7bf2. Thanks for the multiple reviews @bnoordhuis

jbergstroem · 2015-06-01T14:25:03Z

When this lands again, could we possibly look at expanding the cctest suite?

evanlucas · 2015-06-01T14:26:12Z

sure

Options have been moved into the NodeOptions class. A new global, node_options now exists and is used to access the options after the command line arguments have been parsed. PR-URL: nodejs/node#1804 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

evanlucas mentioned this pull request May 26, 2015
Add more robust option parsing [WIP] #1726
Closed
2 tasks

evanlucas force-pushed the getopt branch 5 times, most recently from dd59140 to b06ff7bCompare May 27, 2015 05:27

bnoordhuis reviewed May 27, 2015
View reviewed changes

evanlucas force-pushed the getopt branch 2 times, most recently from c78d8f8 to 65a192eCompare May 27, 2015 18:11

brendanashworth added the c++ Issues and PRs that require attention from people who are familiar with C++. label May 27, 2015

evanlucas force-pushed the getopt branch from 65a192e to 4aa088aCompare May 28, 2015 22:23

bnoordhuis reviewed May 29, 2015
View reviewed changes

Comment threadsrc/node.h Outdated
bnoordhuisMay 29, 2015
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the love of $DEITY, please don't make this public.

evanlucas force-pushed the getopt branch from a6755bc to fcc0c68Compare May 29, 2015 14:52

bnoordhuis reviewed May 29, 2015
View reviewed changes

evanlucas force-pushed the getopt branch from fcc0c68 to 6f41772Compare May 29, 2015 15:31

evanlucas force-pushed the getopt branch 3 times, most recently from a7752f6 to 68357e3Compare May 29, 2015 16:39

evanlucas force-pushed the getopt branch 2 times, most recently from 3019a34 to eadc181Compare May 29, 2015 18:41

brendanashworth mentioned this pull request Jun 1, 2015
test: remove TODO comment #1820
Closed

evanlucas force-pushed the getopt branch from eadc181 to 26ee79cCompare June 1, 2015 13:37

src: add getopt option parser
c0e7bf2
Options have been moved into the NodeOptions class. A new global, node_options now exists and is used to access the options after the command line arguments have been parsed. PR-URL: nodejs#1804 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

evanlucas force-pushed the getopt branch from 26ee79c to c0e7bf2Compare June 1, 2015 13:42

evanlucas closed this Jun 1, 2015

evanlucas deleted the getopt branch June 1, 2015 13:42

evanlucas merged commit c0e7bf2 into nodejs:masterJun 1, 2015

rvagg mentioned this pull request Jun 11, 2015
Release proposal: 2.3.0 #1939
Closed

Uh oh!

Uh oh!

Conversation

evanlucas commented May 26, 2015

Uh oh!

mscdex commented May 27, 2015

Uh oh!

evanlucas commented May 27, 2015

Uh oh!

evanlucas commented May 27, 2015

Uh oh!

bnoordhuisMay 27, 2015

Choose a reason for hiding this comment

Uh oh!

evanlucas commented May 28, 2015

Uh oh!

bnoordhuisMay 29, 2015

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented May 29, 2015

Uh oh!

evanlucas commented May 29, 2015

Uh oh!

bnoordhuisMay 29, 2015

Choose a reason for hiding this comment

Uh oh!

evanlucasMay 29, 2015

Choose a reason for hiding this comment

Uh oh!

bnoordhuisMay 29, 2015

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented May 29, 2015

Uh oh!

evanlucas commented May 29, 2015

Uh oh!

evanlucas commented May 29, 2015

Uh oh!

evanlucas commented May 30, 2015

Uh oh!

evanlucas commented Jun 1, 2015

Uh oh!

bnoordhuis commented Jun 1, 2015

Uh oh!

evanlucas commented Jun 1, 2015

Uh oh!

evanlucas commented Jun 1, 2015

Uh oh!

jbergstroem commented Jun 1, 2015

Uh oh!

evanlucas commented Jun 1, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants