Skip to content

test: add assertions for TextEncoder/Decoder - #18132

Closed
shqld wants to merge 1 commit into
nodejs:masterfrom
shqld:add-test-for-textencoder-decoder
Closed

test: add assertions for TextEncoder/Decoder#18132
shqld wants to merge 1 commit into
nodejs:masterfrom
shqld:add-test-for-textencoder-decoder

Conversation

@shqld

@shqldshqld commented Jan 13, 2018

Copy link
Copy Markdown

Added some assertions for TextEncoder/Decoder to expand branch coverage(https://coverage.nodejs.org/coverage-1385e1bc63665b8c/root/internal/encoding.js.html).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Jan 13, 2018
@addaleax

addaleax commented Jan 18, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/15506/

@addaleaxaddaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 18, 2018
@addaleax

addaleax commented Jan 18, 2018

Copy link
Copy Markdown
Member

Landed in 7972bdf

addaleax pushed a commit that referenced this pull request Jan 18, 2018
Sho Miyamoto@addaleax
test: add assertions for TextEncoder/Decoder
7972bdf
PR-URL: #18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
Sho Miyamoto@evanlucas
test: add assertions for TextEncoder/Decoder
2b13fda
PR-URL: #18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucasevanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
Sho Miyamoto@evanlucas
test: add assertions for TextEncoder/Decoder
5b5f5b1
PR-URL: #18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins

MylesBorins commented Feb 27, 2018

Copy link
Copy Markdown
Contributor

Should this be backported to v6.x-staging or v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@lancelance mentioned this pull request Mar 14, 2018
Closed
3 tasks
@lance

lance commented Mar 14, 2018•
edited
Loading

Copy link
Copy Markdown
Member

@MylesBorins this cannot be backported to v6.x-staging since it depends on #13644 which is labled dont-land-on-v6. I've removed the backport-requested-v6.x label and submitted a backport PR for v8.x-staging.

MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
Sho Miyamoto@MylesBorins
test: add assertions for TextEncoder/Decoder
a618966
Backport-PR-URL: #19358
PR-URL: #18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
Sho Miyamoto@MylesBorins
test: add assertions for TextEncoder/Decoder
88e0f23
Backport-PR-URL: #19358
PR-URL: #18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
Sho Miyamoto@MylesBorins
test: add assertions for TextEncoder/Decoder
e42ab10
Backport-PR-URL: #19358
PR-URL: #18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
Sho Miyamoto@MayaLekova
test: add assertions for TextEncoder/Decoder
1ce221b
PR-URL: nodejs#18132
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@shqld@addaleax@MylesBorins@lance@jasnell@lpinca@TimothyGu@cjihrig@nodejs-github-bot