build: remove bench-* targets

[joyeecheung]

Fixes: #17053

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

Affected core subsystem(s)

build

[maclover7]

Looks like bench-ci got completely removed -- should it also get the "deprecation warning"?

[joyeecheung]

The CI is not using bench-ci so I think the chance of anyone using it is much smaller...

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/12541/

[jasnell]

LGTM but can you add a quick comment to the commit explaining why? :-)

[joyeecheung]

@jasnell Sure, something like:

build: remove bench-* targets
Remove the targets for the following reasons:
- The `bench-*` targets are not used by the benchmark CI. They simply call
`./node benchmark/run.js *` without allowing the user to pass any arguments.
- We tend to use `benchmark/compare.js` to do the actual benchmarking
at the moment.
- The `bench-all` and `bench` targets only run a subset of the benchmarks and
they are not covering all the categories that we have.

This can be fixed during landing.

[joyeecheung]

Landed in 0c8aaf3, thanks!

[bnoordhuis]

@joyeecheung You left in the benchmark/misc/function_call/build/Release/binding.node target. Is that intentional? I can't find anything that actually invokes it.

Is it possible that the benchmark is quietly broken? It exits without error when the binding.node file is missing.

[joyeecheung]

@bnoordhuis No I think I just forgot about benchmark/misc/function_call/build/Release/binding.node...I tried to make the test throw an error in #16934 but I could not find a way to invoke node-gyp properly from within the test so I decided to close it (now come to think of it, it might make sense to invoke make from the script instead...EDIT: no wait there is vcbuild.bat..).

[MylesBorins]

@joyeecheung Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.