Skip to content

fs: migrate FSEventWrap error to JS - #18154

Closed
targos wants to merge 1 commit into
nodejs:masterfrom
targos:errors-fseventwrap
Closed

fs: migrate FSEventWrap error to JS#18154
targos wants to merge 1 commit into
nodejs:masterfrom
targos:errors-fseventwrap

Conversation

@targos

@targostargos commented Jan 15, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

@targostargos added semver-major PRs that contain breaking changes and should be released in the next major version. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Jan 15, 2018
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. labels Jan 15, 2018
@joyeecheung

joyeecheung commented Jan 15, 2018

Copy link
Copy Markdown
Member

This looks like a duplicate of #17851 ? @maclover7 are you still pursuing that PR?

@targos

targos commented Jan 15, 2018

Copy link
Copy Markdown
MemberAuthor

You are right, thanks! I didn't find that PR with my initial search.

@targostargos closed this Jan 15, 2018
@targos
targos deleted the errors-fseventwrap branch October 17, 2020 12:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.errorsIssues and PRs related to JavaScript errors originated in Node.js core.fsIssues and PRs related to the fs subsystem / file system.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@targos@joyeecheung@nodejs-github-bot