Uh oh!
There was an error while loading. Please reload this page.
smalloc: deprecate whole module - #1822
Closed
vkurchatkin wants to merge 2 commits into
Closed
Conversation
`printDeprecationMessage` is used to deprecate modules and execution branches.
bnoordhuis
commented
May 29, 2015
Member
LGTM |
bnoordhuis
commented
May 29, 2015
Member
Suggestion: remove the smalloc entry from the |
It makes no sense to allow people use constants from `smalloc`, since it will be removed completely eventually.
vkurchatkinforce-pushed
the
deprecate-smalloc-2
branch
from
May 29, 2015 12:51
b07b1e3 to
475795bComparevkurchatkin
commented
May 29, 2015
ContributorAuthor
@bnoordhuis right! also maybe we should still expose |
bnoordhuis
commented
May 29, 2015
Member
I'm inclined to say there's no pressing need, I expect the size limit to get dropped sooner rather than later. |
vkurchatkin added a commit
that referenced
this pull request
Jun 4, 2015
`printDeprecationMessage` is used to deprecate modules and execution branches. PR-URL: #1822 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
vkurchatkin added a commit
that referenced
this pull request
Jun 4, 2015
It makes no sense to allow people use constants from `smalloc`, since it will be removed completely eventually. PR-URL: #1822 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
vkurchatkin
commented
Jun 4, 2015
ContributorAuthor
vkurchatkin
commented
Jun 4, 2015
ContributorAuthor
Also, not sure but it probably should be treated as semver-minor |
rvagg added a commit
that referenced
this pull request
Jun 13, 2015
Notable Changes: * libuv: Upgraded to 1.6.0 and 1.6.1, see full ChangeLog for details. (Saúl Ibarra Corretgé) #1905#1889. Highlights include: - Fix TTY becoming blocked on OS X - Fix UDP send callbacks to not to be synchronous - Add uv_os_homedir() (exposed as os.homedir(), see below) * npm: See full release notes for details. (Kat Marchán) #1899. Highlight: - Use GIT_SSH_COMMAND (available as of Git 2.3) * openssl: - Upgrade to 1.0.2b and 1.0.2c, introduces DHE man-in-the-middle protection (Logjam) and fixes malformed ECParameters causing infinite loop (CVE-2015-1788). See the security advisory for full details. (Shigeki Ohtsu) #1950#1958 - Support FIPS mode of OpenSSL, see README for instructions. (Fedor Indutny) #1890 * os: Add os.homedir() method. (Colin Ihrig) #1791 * smalloc: Deprecate whole module. (Vladimir Kurchatkin) #1822 * Add new collaborators: - Alex Kocharin (@rlidwka) - Christopher Monsanto (@monsanto) - Ali Ijaz Sheikh (@ofrobots) - Oleg Elifantiev (@Olegas) - Domenic Denicola (@domenic) - Rich Trott (@Trott)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes no sense to allow people use constants from
smalloc, since it will be removed completely eventually.R=@bnoordhuis