Skip to content

Add example of null to assert.ifError - #18236

Closed
Leko wants to merge 1 commit into
nodejs:masterfrom
Leko:add-example-assert_ifError
Closed

Add example of null to assert.ifError#18236
Leko wants to merge 1 commit into
nodejs:masterfrom
Leko:add-example-assert_ifError

Conversation

@Leko

@LekoLeko commented Jan 18, 2018

Copy link
Copy Markdown
Contributor

This is useful when testing the error argument in callbacks.

— Assert | Node.js v9.4.0 Documentation

error argument would be null or Error.
I think need to add example case of null to help understanding assert.ifError.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-botnodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jan 18, 2018
@targos

targos commented Jan 20, 2018

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/104/

@targos

targos commented Jan 20, 2018

Copy link
Copy Markdown
Member

Commit message nit: start with a lowercase after the subsystem.

@targostargos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 20, 2018
@BridgeARBridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 21, 2018
@BridgeAR

BridgeAR commented Jan 21, 2018

Copy link
Copy Markdown
Member

Landed in 08ada72

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 21, 2018
@Leko@BridgeAR
doc: Add example of null to assert.ifError
08ada72
PR-URL: nodejs#18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Leko
Leko deleted the add-example-assert_ifError branch January 22, 2018 05:53
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@Leko@evanlucas
doc: Add example of null to assert.ifError
4b6297a
PR-URL: #18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@evanlucasevanlucas mentioned this pull request Jan 30, 2018
Merged
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@Leko@evanlucas
doc: Add example of null to assert.ifError
01599e2
PR-URL: #18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@Leko@MylesBorins
doc: Add example of null to assert.ifError
1e8d120
PR-URL: #18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 27, 2018
@Leko@MylesBorins
doc: Add example of null to assert.ifError
d554b8a
PR-URL: #18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Feb 27, 2018
Closed
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@Leko@MayaLekova
doc: Add example of null to assert.ifError
5ac5a7a
PR-URL: nodejs#18236
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

assertIssues and PRs related to the assert subsystem.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Leko@targos@BridgeAR@jasnell@addaleax@cjihrig@MylesBorins@nodejs-github-bot