[v8.x backport] crypto: do not reach into OpenSSL internals for ThrowCryptoError

[yhwang]

There is a perfectly serviceable ERR_get_error function which avoids
having to sniff through the OpenSSL ring buffer like that. It does
return the errors in the opposite order, but that's easily fixed with
std::reverse.

Note this behavior is slightly different in that an ERR_get_error loop
will ultimately clear the error queue, but this is desirable. Leaving
the error queue uncleared means errors in subsequent operations may get
mixed up and cause issues.

Original PR-URL: #16701
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

[yhwang]

Since algorithm header is added above and cmath is included in algorithm, the standard isnan and isinf macros are undefined and new functions are introduced under std namespace. Therefore, need to use std namespace for these 2 functions.
You can see more detailed information in cmath header.

[gibfahn]

@bnoordhuis could you confirm that this makes sense?

[gibfahn]

CI: https://ci.nodejs.org/job/node-test-commit/15625/

EDIT: Wrong job, trying again: https://ci.nodejs.org/job/node-test-commit/15632/

[yhwang]

rebased my branch to upstream/v8.x-staging.

and 2 test cases failed in windows:

not ok 407 parallel/test-tls-server-verify
not ok 506 sequential/test-inspector-bindings # TODO : Fix flaky test

I saw another v8.x backport PR also has the same failures.

[gibfahn]

CI 2: https://ci.nodejs.org/job/node-test-commit/15662/

[yhwang]

CI 2: https://ci.nodejs.org/job/node-test-commit/15662/

The results are the same as the first one. These 2 test cases still failed in Windows:

not ok 407 parallel/test-tls-server-verify
not ok 505 sequential/test-inspector-async-call-stack # TODO : Fix flaky test

[bnoordhuis]

@yhwang Can you rebase? The test failures are known flakes.

[yhwang]

@bnoordhuis I just rebased. Please kick off another CI to verify it. Thanks.

[gibfahn]

CI: https://ci.nodejs.org/job/node-test-commit/15701/

[bnoordhuis]

@yhwang I'm afraid this needs another rebase.

[yhwang]

@bnoordhuis sure thing and it's done.

[Edit] Please kick off a CI to verify it it

[yhwang]

Rebase again because of the conflict and please kick off a CI. Thanks.

[mhdawson]

CI run: https://ci.nodejs.org/job/node-test-pull-request/13070/

[yhwang]

failed on windows-test. it complains about cctest.exe not found. However, the windows build task passed, I downloaded the binary.tar.gz and the cctest.exe and node.exe inside the tarball work well.

[gibfahn]

Sorry @yhwang , looks like this needs (yet another) rebase after the V8 update.

[yhwang]

rebase failed and need to solve lots of conflict in v8. Let me use a new branch which is from the latest v8.x-staging. that's will be easier.

[yhwang]

CI: https://ci.nodejs.org/job/node-test-commit/16377/

[gibfahn]

rebase failed and need to solve lots of conflict in v8. Let me use a new branch which is from the latest v8.x-staging. that's will be easier.

Yeah I frequently just do reset --hard up/v8.x-staging; git cherry-pick mybranch instead of actually rebasing.

[gibfahn]

@bnoordhuis would you mind taking a quick look?

[gibfahn]

Landed in 8cc0ea7