lib: micro-optimize EventEmitter#removeListener()

benchmark/common.js

@@ -187,7 +187,7 @@ Benchmark.prototype.end = function(operations) {
 Benchmark.prototype.report = function(value) {
  var heading = this.getHeading();
  if (!silent)
- console.log('%s: %s', heading, value.toPrecision(5));
+ console.log('%s: %s', heading, value.toFixed(0));
  process.exit(0);
 };
 

benchmark/events/ee-add-remove.js

@@ -0,0 +1,23 @@
+var common = require('../common.js');
+var events = require('events');
+
+var bench = common.createBenchmark(main, {n: [25e4]});
+
+function main(conf) {
+ var n = conf.n | 0;
+
+ var ee = new events.EventEmitter();
+ var listeners = [];
+
+ for (var k = 0; k < 10; k += 1)
+ listeners.push(function() {});
+
+ bench.start();
+ for (var i = 0; i < n; i += 1) {
+ for (var k = listeners.length; --k >= 0; /* empty */)
+ ee.on('dummy', listeners[k]);
+ for (var k = listeners.length; --k >= 0; /* empty */)
+ ee.removeListener('dummy', listeners[k]);
+ }
+ bench.end(n);
+}

lib/events.js

@@ -246,7 +246,7 @@ EventEmitter.prototype.removeListener =
  list.length = 0;
  delete this._events[type];
  } else {
-list.splice(position, 1);
+spliceOne(list, position);
  }
 
  if (this._events.removeListener)
@@ -318,3 +318,10 @@ EventEmitter.listenerCount = function(emitter, type) {
  ret = emitter._events[type].length;
  return ret;
 };
+
+// About 1.5x faster than the two-arg version of Array#splice().
+function spliceOne(list, index) {
+ for (var i = index, k = i + 1, n = list.length; k < n; i += 1, k += 1)
+ list[i] = list[k];
+ list.pop();
+}