Skip to content

build: do not surpress output in make doc-only - #18507

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:no-silent-doc
Closed

build: do not surpress output in make doc-only#18507
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:no-silent-doc

Conversation

@joyeecheung

Copy link
Copy Markdown
Member

This helps to show the cause of errors in the CI.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

This helps to show the cause of errors in the CI.
@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Feb 1, 2018
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2018
@joyeecheung

Copy link
Copy Markdown
MemberAuthor

@gibfahn

Copy link
Copy Markdown
Member

Nit: surpress -> suppress in commit message

joyeecheung added a commit that referenced this pull request Feb 8, 2018
This helps to show the cause of errors in the CI.
PR-URL: #18507
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@joyeecheung

Copy link
Copy Markdown
MemberAuthor

Landed in b505716 with #18507 (comment) addressed, thanks!

MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This helps to show the cause of errors in the CI.
PR-URL: #18507
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This helps to show the cause of errors in the CI.
PR-URL: #18507
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This helps to show the cause of errors in the CI.
PR-URL: #18507
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
This helps to show the cause of errors in the CI.
PR-URL: #18507
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Apr 13, 2018
This helps to show the cause of errors in the CI.
PR-URL: #18507
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahn

Copy link
Copy Markdown
Member

Conflicts on 6.x so skipped it.

@MylesBorinsMylesBorins mentioned this pull request May 2, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
This helps to show the cause of errors in the CI.
PR-URL: nodejs#18507
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung@gibfahn@danbev@jasnell@cjihrig@BridgeAR@nodejs-github-bot