Uh oh!
There was an error while loading. Please reload this page.
test: remove destructor from node_test_fixture - #18524
Closed
danbev wants to merge 1 commit into
Closed
Conversation
This commit removes the destructor from node_test_fixture.h which calls the TearDown function causing TearDown to be called twice. This also allows us to remove the check of the platform_ in TearDown. Also the Setup/TearDown functions in AliasBufferTest are removed as they are not necessary.
danbev
commented
Feb 2, 2018
ContributorAuthor
danbev
commented
Feb 2, 2018
ContributorAuthor
test/node-test-commit-plinux failure looks unrelatedBuilding addon /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons-napi/4_object_factory/gyp info spawn /usr/bin/pythongyp info spawn args [ '/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/deps/npm/node_modules/node-gyp/gyp/gyp_main.py',gyp info spawn args 'binding.gyp',gyp info spawn args '-f',gyp info spawn args 'make',gyp info spawn args '-I',gyp info spawn args '/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons/03_object_factory/build/config.gypi',gyp info spawn args '-I',gyp info spawn args '/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/deps/npm/node_modules/node-gyp/addon.gypi',gyp info spawn args '-I',gyp info spawn args '/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/common.gypi',gyp info spawn args '-Dlibrary=shared_library',gyp info spawn args '-Dvisibility=default',gyp info spawn args '-Dnode_root_dir=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404',gyp info spawn args '-Dnode_gyp_dir=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/deps/npm/node_modules/node-gyp',gyp info spawn args '-Dnode_lib_file=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/$(Configuration)/node.lib',gyp info spawn args '-Dmodule_root_dir=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons/03_object_factory',gyp info spawn args '-Dnode_engine=v8',gyp info spawn args '--depth=.',gyp info spawn args '--no-parallel',gyp info spawn args '--generator-output',gyp info spawn args 'build',gyp info spawn args '-Goutput_dir=.' ]gyp info spawn makegyp info make[2]: Entering directory `/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons-napi/4_object_factory/build'gyp info it worked if it ends with okgyp info using node-gyp@3.6.2gyp info using node@10.0.0-pre | linux | ppc64gyp info chdir /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons-napi/4_object_factory/gyp info spawn /usr/bin/pythongyp info spawn args [ '/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/deps/npm/node_modules/node-gyp/gyp/gyp_main.py',gyp info spawn args 'binding.gyp',gyp info spawn args '-f',gyp info spawn args 'make',gyp info spawn args '-I',gyp info spawn args '/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons-napi/4_object_factory/build/config.gypi',gyp info spawn args '-I',gyp info spawn args '/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/deps/npm/node_modules/node-gyp/addon.gypi',gyp info spawn args '-I',gyp info spawn args '/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/common.gypi',gyp info spawn args '-Dlibrary=shared_library',gyp info spawn args '-Dvisibility=default',gyp info spawn args '-Dnode_root_dir=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404',gyp info spawn args '-Dnode_gyp_dir=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/deps/npm/node_modules/node-gyp',gyp info spawn args '-Dnode_lib_file=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/$(Configuration)/node.lib',gyp info spawn args '-Dmodule_root_dir=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons-napi/4_object_factory',gyp info spawn args '-Dnode_engine=v8',gyp info spawn args '--depth=.',gyp info spawn args '--no-parallel',gyp info spawn args '--generator-output',gyp info spawn args 'build',gyp info spawn args '-Goutput_dir=.' ]gyp info spawn makegyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build', '--jobs', 8 ]make[2]: Entering directory `/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/out'spawn args CC(target) Release/obj.target/binding/binding.o [ 'BUILDTYPE=Release', '-C', 'build', '--jobs', 8 ] touch 29a4abf18ff5ed2e75fa1308c90336966b01bb40.intermediate CXX(target) Release/obj.target/addon/addon.o LD_LIBRARY_PATH=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/out/Release/lib.host:/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/out/Release/lib.target:$LD_LIBRARY_PATH; export LD_LIBRARY_PATH; cd ../deps/v8/src/inspector; mkdir -p /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/out/Release/obj/gen/src/inspector/protocol /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/out/Release/obj/gen/include/inspector; python ../../third_party/inspector_protocol/CodeGenerator.py --jinja_dir ../../third_party --output_base "/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/out/Release/obj/gen/src/inspector" --config inspector_protocol_config.json SOLINK_MODULE(target) Release/obj.target/addon.node SOLINK_MODULE(target) Release/obj.target/binding.node COPY Release/addon.node COPY Release/binding.nodemake[2]: Leaving directory `/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons/03_object_factory/build'make[2]: write errorgyp ERR! build error gyp ERR! stack Error: `make` failed with exit code: 1gyp ERR! stack at ChildProcess.onExit (/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/deps/npm/node_modules/node-gyp/lib/build.js:258:23)gyp ERR! stack at ChildProcess.emit (events.js:131:13)gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)gyp ERR! System Linux 4.2.0-42-powerpc64-smpgyp ERR! command "/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/out/Release/node" "/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/deps/npm/node_modules/node-gyp/bin/node-gyp" "--loglevel=info" "rebuild" "--python=/usr/bin/python" "--directory=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons/03_object_factory/" "--nodedir=/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404"make[2]: Leaving directory `/home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons-napi/4_object_factory/build'gyp ERR! cwd /home/iojs/build/workspace/node-test-commit-plinux/nodes/ppcbe-ubuntu1404/test/addons/03_object_factorygyp ERR! node -v v10.0.0-pregyp ERR! node-gyp -v v3.6.2gyp ERR! not ok gyp info ok make[1]: *** [test/addons/.buildstamp] Error 1make[1]: *** Waiting for unfinished jobs.... |
jasnell
approved these changes
Feb 2, 2018
danbev
commented
Feb 5, 2018
ContributorAuthor
Landed in 83c9315. |
danbev added a commit
that referenced
this pull request
Feb 5, 2018
This commit removes the destructor from node_test_fixture.h which calls the TearDown function causing TearDown to be called twice. This also allows us to remove the check of the platform_ in TearDown. Also the Setup/TearDown functions in AliasBufferTest are removed as they are not necessary. PR-URL: #18524 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 21, 2018
This commit removes the destructor from node_test_fixture.h which calls the TearDown function causing TearDown to be called twice. This also allows us to remove the check of the platform_ in TearDown. Also the Setup/TearDown functions in AliasBufferTest are removed as they are not necessary. PR-URL: #18524 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 21, 2018
This commit removes the destructor from node_test_fixture.h which calls the TearDown function causing TearDown to be called twice. This also allows us to remove the check of the platform_ in TearDown. Also the Setup/TearDown functions in AliasBufferTest are removed as they are not necessary. PR-URL: #18524 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 21, 2018
This commit removes the destructor from node_test_fixture.h which calls the TearDown function causing TearDown to be called twice. This also allows us to remove the check of the platform_ in TearDown. Also the Setup/TearDown functions in AliasBufferTest are removed as they are not necessary. PR-URL: #18524 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Mar 20, 2018
This commit removes the destructor from node_test_fixture.h which calls the TearDown function causing TearDown to be called twice. This also allows us to remove the check of the platform_ in TearDown. Also the Setup/TearDown functions in AliasBufferTest are removed as they are not necessary. PR-URL: #18524 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 28, 2018
This commit removes the destructor from node_test_fixture.h which calls the TearDown function causing TearDown to be called twice. This also allows us to remove the check of the platform_ in TearDown. Also the Setup/TearDown functions in AliasBufferTest are removed as they are not necessary. PR-URL: #18524 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Mar 30, 2018
This commit removes the destructor from node_test_fixture.h which calls the TearDown function causing TearDown to be called twice. This also allows us to remove the check of the platform_ in TearDown. Also the Setup/TearDown functions in AliasBufferTest are removed as they are not necessary. PR-URL: #18524 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This commit removes the destructor from node_test_fixture.h which calls the TearDown function causing TearDown to be called twice. This also allows us to remove the check of the platform_ in TearDown. Also the Setup/TearDown functions in AliasBufferTest are removed as they are not necessary. PR-URL: nodejs#18524 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the destructor from node_test_fixture.h which calls
the TearDown function causing TearDown to be called twice. This also
allows us to remove the check of the platform_ in TearDown.
Also the Setup/TearDown functions in AliasBufferTest are removed as they
are not necessary.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test