Skip to content

test: do not check TXT content in test-dns-any - #18547

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:fix-test-dns-any
Closed

test: do not check TXT content in test-dns-any#18547
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:fix-test-dns-any

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Feb 3, 2018

Copy link
Copy Markdown
Member

google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.

Note: this is a test under test/internet which is not normally run, that's why this has been broken without being noticed.

> nslookup -type=TXT google.com
Server: 8.8.8.8
Address:	8.8.8.8#53
Non-authoritative answer:
google.com	text = "docusign=05958488-4752-4ef2-95eb-aa7ba8a3bd0e"
google.com	text = "v=spf1 include:_spf.google.com ~all"
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

cc @XadillaX

Affected core subsystem(s)

@joyeecheung
test: do not check TXT content in test-dns-any
11dae6c
google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 3, 2018
XadillaX
XadillaX approved these changes Feb 3, 2018
View reviewed changes

@XadillaXXadillaX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@BridgeAR

BridgeAR commented Feb 3, 2018

Copy link
Copy Markdown
Member

@joyeecheung do we have a Jenkins job that would actually run these tests?

@joyeecheung

joyeecheung commented Feb 3, 2018

Copy link
Copy Markdown
MemberAuthor

@BridgeAR No, not at the moment.

@joyeecheung

joyeecheung commented Feb 3, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/12921/

apapirovski
apapirovski approved these changes Feb 4, 2018
View reviewed changes
Comment threadtest/internet/test-dns-any.js
checkTXT(r) {
assert.ok(Array.isArray(r.entries));
assert.ok(r.entries.length > 0);
r.entries.forEach((txt) => {

@apapirovskiapapirovskiFeb 4, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something like:

assert(r.entries.some(txt=>txt.startsWith('v=spf1')));

@joyeecheungjoyeecheungFeb 4, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is the records will be in different 'r's, instead of different entries in the same 'r' (probably something we need to fix, though should be in another PR IMO

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2018
@joyeecheung

joyeecheung commented Feb 7, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in e542920, thanks!

joyeecheung added a commit that referenced this pull request Feb 7, 2018
@joyeecheung
test: do not check TXT content in test-dns-any
e542920
google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.
PR-URL: #18547
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR closed this Feb 7, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@joyeecheung@MylesBorins
test: do not check TXT content in test-dns-any
c230219
google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.
PR-URL: #18547
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@joyeecheung@MylesBorins
test: do not check TXT content in test-dns-any
f3bf159
google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.
PR-URL: #18547
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@joyeecheung@MylesBorins
test: do not check TXT content in test-dns-any
ef2d9c2
google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.
PR-URL: #18547
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
@joyeecheungjoyeecheung mentioned this pull request Feb 27, 2018
Closed
@joyeecheungjoyeecheung mentioned this pull request Mar 30, 2018
Closed
joyeecheung added a commit to joyeecheung/node that referenced this pull request Mar 30, 2018
@joyeecheung
test: do not check TXT content in test-dns-any
f969be6
google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.
PR-URL: nodejs#18547
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Apr 11, 2018
@joyeecheung@gibfahn
test: do not check TXT content in test-dns-any
bff7258
google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.
PR-URL: #18547
Backport-PR-URL: #19706
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@joyeecheung@MayaLekova
test: do not check TXT content in test-dns-any
7a6b023
google.com added another TXT record which broke this test.
This removes the check on the content of the TXT record
since that depends on an external state subject to change.
PR-URL: nodejs#18547
Reviewed-By: Khaidi Chu <i@2333.moe>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+3 more reviewers
@apapirovskiapapirovskiapapirovski approved these changes
@XadillaXXadillaXXadillaX approved these changes
@maclover7maclover7maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@joyeecheung@BridgeAR@apapirovski@jasnell@cjihrig@XadillaX@maclover7@gibfahn@nodejs-github-bot