Uh oh!
There was an error while loading. Please reload this page.
test: remove unneeded comment task - #1858
Closed
Trott wants to merge 1 commit into
Closed
Conversation
cjihrig
commented
Jun 1, 2015
Contributor
LGTM |
brendanashworth pushed a commit
that referenced
this pull request
Jun 1, 2015
PR-URL: #1858 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
brendanashworth
commented
Jun 1, 2015
Contributor
Thanks Rich, landed in 8704c58. |
andrewdeandrade pushed a commit
to andrewdeandrade/node
that referenced
this pull request
Jun 3, 2015
PR-URL: nodejs/node#1858 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test queried about in the TODO comment would result in a HTTP request to localhost and falls outside of the scope of the test file in which it appears, which tests that protocols other than HTTP and HTTPS throw errors.
ref: #264