Skip to content

fs: make URL paths no longer experimental - #18591

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:fs-graduate-url-path
Closed

fs: make URL paths no longer experimental#18591
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:fs-graduate-url-path

Conversation

@jasnell

@jasnelljasnell commented Feb 6, 2018

Copy link
Copy Markdown
Member

Specifying fs paths as URLs isn't really experimental any more.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Feb 6, 2018
@BridgeAR

BridgeAR commented Feb 6, 2018

Copy link
Copy Markdown
Member

@jasnell please always trigger a CI after creating a PR.

TimothyGu
TimothyGu approved these changes Feb 7, 2018
View reviewed changes

@TimothyGuTimothyGu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change could maybe be added to changes.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 10, 2018
@BridgeAR

BridgeAR commented Feb 12, 2018

Copy link
Copy Markdown
Member

Landed in 2287dea 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 12, 2018
@jasnell@BridgeAR
fs: make URL paths no longer experimental
2287dea
PR-URL: nodejs#18591
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@jasnell@MylesBorins
fs: make URL paths no longer experimental
495c412
PR-URL: #18591
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@jasnell@MylesBorins
fs: make URL paths no longer experimental
5e3c792
PR-URL: #18591
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@jasnell@MylesBorins
fs: make URL paths no longer experimental
35ce3a8
PR-URL: #18591
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 13, 2018
@MylesBorins

MylesBorins commented Apr 13, 2018

Copy link
Copy Markdown
Contributor

should this have been semver-minor?

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@jasnell@MayaLekova
fs: make URL paths no longer experimental
57a3e58
PR-URL: nodejs#18591
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+3 more reviewers
@evanlucasevanlucasevanlucas approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
@starkwangstarkwangstarkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.fsIssues and PRs related to the fs subsystem / file system.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@jasnell@BridgeAR@MylesBorins@evanlucas@lpinca@TimothyGu@cjihrig@joyeecheung@starkwang@nodejs-github-bot