Uh oh!
There was an error while loading. Please reload this page.
doc: add missing "changes" key in YAML comment - #18605
Closed
lpinca wants to merge 1 commit into
Closed
Conversation
lpinca
commented
Feb 6, 2018
MemberAuthor
addaleax
approved these changes
Feb 6, 2018
apapirovski
approved these changes
Feb 6, 2018
addaleax
commented
Feb 6, 2018
Member
Landed in 610cac2 |
addaleax pushed a commit
that referenced
this pull request
Feb 6, 2018
PR-URL: #18605 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
3 tasks
MylesBorins pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18605 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18605 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18605 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
gibfahn
commented
Apr 13, 2018
Member
Depends on #15752, which is semver-minor |
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18605 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a YAML parse issue introduces in commit a899576.
It should unbreak CI.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc