Skip to content

http2: use _final instead of on('finish') - #18609

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:http2-final
Closed

http2: use _final instead of on('finish')#18609
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:http2-final

Conversation

@addaleax

@addaleaxaddaleax commented Feb 7, 2018

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

net

@nodejs-github-botnodejs-github-bot added dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Feb 7, 2018
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 10, 2018
@BridgeAR

BridgeAR commented Feb 10, 2018•
edited
Loading

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/13090/

@addaleax

addaleax commented Feb 11, 2018

Copy link
Copy Markdown
MemberAuthor

New CI: https://ci.nodejs.org/job/node-test-commit/16162/

@BridgeAR

BridgeAR commented Feb 12, 2018

Copy link
Copy Markdown
Member

@addaleax is this semver-minor?

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 12, 2018
@addaleax@BridgeAR
http2: use _final instead of on('finish')
377cfd6
PR-URL: nodejs#18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@BridgeAR

BridgeAR commented Feb 12, 2018

Copy link
Copy Markdown
Member

Landed in 377cfd6 🎉

@addaleax
addaleax deleted the http2-final branch February 12, 2018 16:11
@addaleax

addaleax commented Feb 12, 2018

Copy link
Copy Markdown
MemberAuthor

@BridgeAR No, it’s just changing internals. Thanks for landing this!

@addaleaxaddaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 12, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@addaleax@MylesBorins
http2: use _final instead of on('finish')
84c95c5
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@addaleax@MylesBorins
http2: use _final instead of on('finish')
5e778b4
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@addaleax@MylesBorins
http2: use _final instead of on('finish')
5e5276b
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@addaleax@kjin
http2: use _final instead of on('finish')
7b03c17
PR-URL: nodejs#18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@addaleax@MylesBorins
http2: use _final instead of on('finish')
28a2729
Backport-PR-URL: #20456
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorinsMylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@addaleax@MayaLekova
http2: use _final instead of on('finish')
b018fd1
PR-URL: nodejs#18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@addaleax@MylesBorins
http2: use _final instead of on('finish')
b895ca9
Backport-PR-URL: #20456
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
@addaleax@MylesBorins
http2: use _final instead of on('finish')
20fb59f
Backport-PR-URL: #20456
PR-URL: #18609
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
+1 more reviewer
@apapirovskiapapirovskiapapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@addaleax@BridgeAR@apapirovski@jasnell@nodejs-github-bot