debugger: improve ESRCH error message by JacksonTian · Pull Request #1863 · nodejs/node

JacksonTian · 2015-06-01T14:18:04Z

When use iojs debug -p <pid> with an invalid pid,
the debugger print internal error message also,
it not enough smart.

Fishrock123 · 2015-06-01T14:41:19Z

SGTM..

bnoordhuis · 2015-06-01T15:47:05Z

Can you use const here?

JacksonTian · 2015-06-02T07:16:54Z

Thank you. @Fishrock123 @bnoordhuis @thefourtheye

bnoordhuis · 2015-06-02T07:56:56Z

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/749/

JacksonTian · 2015-06-02T08:45:36Z

The smart os has a timeout error. It seems not related. And the raspbian is so slowly.

在 2015年6月2日，下午3:57，Ben Noordhuis notifications@github.com 写道：
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/749/https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/749/
—
Reply to this email directly or view it on GitHub #1863 (comment).

bnoordhuis · 2015-06-03T17:20:47Z

LGTM but can I have one more LGTM from @nodejs/collaborators? Perhaps it would be good to have a regression test for this.

Fishrock123 · 2015-06-03T17:26:27Z

Shouldn't this be stderr then?

Or simply, console.error?

Fishrock123 · 2015-06-03T17:27:11Z

A question, but LGTM, tests are always nice. :)

indutny · 2015-06-03T17:31:17Z

LGTM, with one nit from @Fishrock123

JacksonTian · 2015-06-05T03:06:38Z

Add the regression test.

yosuke-furukawa · 2015-06-05T03:21:52Z

We don't need to use escape \ enclosed by " or `.
console.error(`Target process: ${pid} doesn't exist.`);

Didn’t see template string be used in node core, so I don’t use it. If it’s recommend, I will replace it.
在 2015年6月5日，上午11:21，Yosuke Furukawa notifications@github.com 写道：
In lib/_debugger.js #1863 (comment):
@@ -1639,7 +1639,16 @@ Interface.prototype.trySpawn = function(cb) {
} else if (this.args.length === 3) {
// node debug -p pid
if (this.args[1] === '-p' && /^\d+$/.test(this.args[2])) {
process._debugProcess(parseInt(this.args[2], 10));
const pid = parseInt(this.args[2], 10);
try {
process._debugProcess(pid);
} catch (e) {
if (e.code === 'ESRCH') {
console.error('Target process: ' + pid + ' doesn\'t exist.');
We don't need to use escape \ enclosed by " or `.
console.error(Target process: ${pid} doesn't exist.);
—
Reply to this email directly or view it on GitHub https://github.com/nodejs/io.js/pull/1863/files#r31785321.

Yes, We can use template string literals. We switched closure-linter to eslint.
https://github.com/nodejs/io.js/blob/master/.eslintrc#L7

When use `iojs debug -p <pid>` with an invalid pid, the debugger print internal error message also, it not enough smart.

JacksonTian · 2015-06-05T06:54:01Z

@yosuke-furukawa used the template string.

bnoordhuis · 2015-06-05T10:48:43Z

LGTM. CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/771/

@yosuke-furukawa LGTY?

yosuke-furukawa · 2015-06-05T11:00:03Z

Yes. LGTM.

bnoordhuis · 2015-06-05T11:11:19Z

Here's another test run: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/772/ - the last one failed because of style issues in the test case...

When using `iojs debug -p <pid>` with an invalid pid, the debugger printed an internal error message because it wasn't smart enough to figure out that the target process didn't exist. Now it is. PR-URL: #1863 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com>

bnoordhuis · 2015-06-05T11:36:35Z

Thanks @JacksonTian, landed in 81029c6.

Fishrock123 added the debugger label Jun 1, 2015

bnoordhuis reviewed Jun 1, 2015
View reviewed changes

Comment threadlib/_debugger.js Outdated
bnoordhuisJun 1, 2015
Copy link
Copy Markdown
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use const here?

JacksonTian force-pushed the debug_process branch from 58827e7 to bf9bffaCompare June 2, 2015 02:03

bnoordhuis force-pushed the master branch from 311c3e4 to b926718Compare June 2, 2015 17:25

Fishrock123 reviewed Jun 3, 2015
View reviewed changes

JacksonTian force-pushed the debug_process branch from bf9bffa to cec83f7Compare June 5, 2015 02:41

yosuke-furukawa reviewed Jun 5, 2015
View reviewed changes

debugger: improve ESRCH error message
2cdc830
When use `iojs debug -p <pid>` with an invalid pid, the debugger print internal error message also, it not enough smart.

JacksonTian force-pushed the debug_process branch from cec83f7 to 2cdc830Compare June 5, 2015 06:51

bnoordhuis closed this Jun 5, 2015

rvagg mentioned this pull request Jun 11, 2015
Release proposal: 2.3.0 #1939
Closed

Uh oh!

Uh oh!

Conversation

JacksonTian commented Jun 1, 2015

Uh oh!

Fishrock123 commented Jun 1, 2015

Uh oh!

bnoordhuisJun 1, 2015

Choose a reason for hiding this comment

Uh oh!

JacksonTian commented Jun 2, 2015

Uh oh!

bnoordhuis commented Jun 2, 2015

Uh oh!

JacksonTian commented Jun 2, 2015

Uh oh!

bnoordhuis commented Jun 3, 2015

Uh oh!

Fishrock123Jun 3, 2015

Choose a reason for hiding this comment

Uh oh!

thefourtheyeJun 3, 2015

Choose a reason for hiding this comment

Uh oh!

Fishrock123 commented Jun 3, 2015

Uh oh!

indutny commented Jun 3, 2015

Uh oh!

JacksonTian commented Jun 5, 2015

Uh oh!

yosuke-furukawaJun 5, 2015

Choose a reason for hiding this comment

Uh oh!

JacksonTianJun 5, 2015

Choose a reason for hiding this comment

Uh oh!

yosuke-furukawaJun 5, 2015

Choose a reason for hiding this comment

Uh oh!

JacksonTian commented Jun 5, 2015

Uh oh!

bnoordhuis commented Jun 5, 2015

Uh oh!

yosuke-furukawa commented Jun 5, 2015

Uh oh!

bnoordhuis commented Jun 5, 2015

Uh oh!

bnoordhuis commented Jun 5, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants