Skip to content

crypto: fix meta and description - #18651

Closed
tniessen wants to merge 2 commits into
nodejs:masterfrom
tniessen:crypto-fix-cipher-description
Closed

crypto: fix meta and description#18651
tniessen wants to merge 2 commits into
nodejs:masterfrom
tniessen:crypto-fix-cipher-description

Conversation

@tniessen

@tniessentniessen commented Feb 8, 2018

Copy link
Copy Markdown
Member

It seems like these slipped through in #8281 and #12223. Requesting reviews from authors.

Checklist
Affected core subsystem(s)

doc

@tniessentniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 8, 2018
@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Feb 8, 2018
@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 8, 2018
@BridgeAR

BridgeAR commented Feb 8, 2018

Copy link
Copy Markdown
Member

@tniessen please always trigger a CI after opening a PR :-)

@BridgeAR

BridgeAR commented Feb 8, 2018

Copy link
Copy Markdown
Member

Light-CI https://ci.nodejs.org/job/node-test-commit-light/238/

tniessen added a commit that referenced this pull request Feb 9, 2018
@tniessen
doc: fix description of createDecipheriv
4927d94
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
tniessen added a commit that referenced this pull request Feb 9, 2018
@tniessen
doc: add missing meta for createCipheriv
95a35bc
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@tniessen

tniessen commented Feb 9, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 4927d94, 95a35bc.

@tniessentniessen closed this Feb 9, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen@MylesBorins
doc: fix description of createDecipheriv
27d10a5
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen@MylesBorins
doc: add missing meta for createCipheriv
1d0be7c
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen@MylesBorins
doc: fix description of createDecipheriv
d441904
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen@MylesBorins
doc: add missing meta for createCipheriv
64aae93
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen@MylesBorins
doc: fix description of createDecipheriv
b4d04a8
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen@MylesBorins
doc: add missing meta for createCipheriv
97b5c1f
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen@MylesBorins
doc: fix description of createDecipheriv
affddd3
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen@MylesBorins
doc: add missing meta for createCipheriv
832e052
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@gibfahn

gibfahn commented Apr 13, 2018

Copy link
Copy Markdown
Member

95a35bc had conflicts on v6.x so I skipped it, if someone would like to backport feel free (although I don't think it's a high priority one).

gibfahn pushed a commit that referenced this pull request Apr 13, 2018
@tniessen@gibfahn
doc: fix description of createDecipheriv
0071560
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
gibfahn pushed a commit that referenced this pull request Apr 13, 2018
@tniessen@gibfahn
doc: fix description of createDecipheriv
0067bcc
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
gibfahn pushed a commit that referenced this pull request Apr 13, 2018
@tniessen@gibfahn
doc: add missing meta for createCipheriv
f8ad381
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Apr 13, 2018
Merged
@MylesBorinsMylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@tniessen@MayaLekova
doc: fix description of createDecipheriv
b29884f
PR-URL: nodejs#18651
Refs: nodejs#12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@tniessen@MayaLekova
doc: add missing meta for createCipheriv
4a73e7b
PR-URL: nodejs#18651
Refs: nodejs#8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@tniessentniessen removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 12, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@TimothyGuTimothyGuTimothyGu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cryptoIssues and PRs related to the crypto subsystem.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@BridgeAR@gibfahn@lpinca@TimothyGu@nodejs-github-bot