Skip to content

Refactor test-tls-pause - #18714

Closed
juggernaut451 wants to merge 3 commits into
nodejs:masterfrom
juggernaut451:refactor
Closed

Refactor test-tls-pause#18714
juggernaut451 wants to merge 3 commits into
nodejs:masterfrom
juggernaut451:refactor

Conversation

@juggernaut451

@juggernaut451juggernaut451 commented Feb 11, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Changes that are done in file are :

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 11, 2018
starkwang
starkwang approved these changes Feb 13, 2018
View reviewed changes

@starkwangstarkwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott
Trott reviewed Feb 14, 2018
View reviewed changes
Comment threadtest/parallel/test-tls-pause.js Outdated
common.skip('missing crypto');

// This test ensures that the data received over tls-server after pause
// is same as what it was send

@TrottTrottFeb 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: send -> sent.

@juggernaut451juggernaut451Feb 14, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done

@juggernaut451juggernaut451Feb 16, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott Thanks for feedback!

richardlau
richardlau reviewed Feb 14, 2018
View reviewed changes
Comment threadtest/parallel/test-tls-pause.js Outdated
}));

server.listen(0, function() {
server.listen(0, () => {

@richardlaurichardlauFeb 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callback to listen could (should?) also be wrapped in common.mustCall.

@juggernaut451juggernaut451Feb 14, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes done

@jasnell

jasnell commented Feb 16, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/13206/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 16, 2018
@BridgeAR

BridgeAR commented Feb 17, 2018•
edited
Loading

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/13241/

@BridgeAR

BridgeAR commented Feb 17, 2018

Copy link
Copy Markdown
Member

Landed in c9b42c4 🎉

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 17, 2018
@juggernaut451@BridgeAR
test: refactor parallel/test-tls-pause
c9b42c4
Use arrow functions and common.mustCall() and add a description.
PR-URL: nodejs#18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451@MylesBorins
test: refactor parallel/test-tls-pause
e7a415d
Use arrow functions and common.mustCall() and add a description.
PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451@MylesBorins
test: refactor parallel/test-tls-pause
72484e5
Use arrow functions and common.mustCall() and add a description.
PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@juggernaut451@MylesBorins
test: refactor parallel/test-tls-pause
d73f214
Use arrow functions and common.mustCall() and add a description.
PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@juggernaut451@MayaLekova
test: refactor parallel/test-tls-pause
b909318
Use arrow functions and common.mustCall() and add a description.
PR-URL: nodejs#18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@juggernaut451@MylesBorins
test: refactor parallel/test-tls-pause
e5130db
Use arrow functions and common.mustCall() and add a description.
PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@juggernaut451@MylesBorins
test: refactor parallel/test-tls-pause
b197422
Use arrow functions and common.mustCall() and add a description.
PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@juggernaut451@MylesBorins
test: refactor parallel/test-tls-pause
ecd8659
Use arrow functions and common.mustCall() and add a description.
PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@juggernaut451@MylesBorins
test: refactor parallel/test-tls-pause
ffa7b50
Use arrow functions and common.mustCall() and add a description.
PR-URL: #18714
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
+3 more reviewers
@daynindaynindaynin approved these changes
@hiroppyhiroppyhiroppy approved these changes
@starkwangstarkwangstarkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@juggernaut451@jasnell@BridgeAR@Trott@daynin@addaleax@lpinca@hiroppy@richardlau@starkwang@MylesBorins@nodejs-github-bot