Skip to content

doc: add process.debugPort to doc/api/process.md - #18716

Closed
flickz wants to merge 4 commits into
nodejs:masterfrom
flickz:fix/18639
Closed

doc: add process.debugPort to doc/api/process.md#18716
flickz wants to merge 4 commits into
nodejs:masterfrom
flickz:fix/18639

Conversation

@flickz

@flickzflickz commented Feb 11, 2018

Copy link
Copy Markdown
Contributor

Ref: #18639

Added process.debugPort to process api doc

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Feb 11, 2018
cjihrig
cjihrig approved these changes Feb 11, 2018
View reviewed changes
Comment threaddoc/api/process.md Outdated
-->
* {number}

A port number for the debugger to listen to.

@cjihrigcjihrigFeb 11, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rephrase as "The port used by Node's debugger when it is enabled." or something similar.

@flickzflickzFeb 11, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright

BridgeAR
BridgeAR reviewed Feb 12, 2018
View reviewed changes
Comment threaddoc/api/process.md Outdated
-->
* {number}

The port used by Node's debugger when enabled.

@BridgeARBridgeARFeb 12, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually called Node.js so it should be called Node.js's.

@flickzflickzFeb 12, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted

@BridgeARBridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Feb 13, 2018
@targos

targos commented Feb 16, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request-lite/172/

BridgeAR
BridgeAR reviewed Feb 17, 2018
View reviewed changes
Comment threaddoc/api/process.md Outdated
The port used by Node.js's debugger when enabled.

```js
process.debugPort = 5858;

@BridgeARBridgeARFeb 17, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter complains about the indentation. Please do not use any spaces here :-)

@BridgeARBridgeAR removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 17, 2018
@flickz

flickz commented Feb 19, 2018

Copy link
Copy Markdown
ContributorAuthor

@BridgeAR Resolved

@mmarchini

mmarchini commented Feb 26, 2018

Copy link
Copy Markdown
Contributor

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite/195/

@mmarchini

mmarchini commented Feb 26, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Landed in 65ca369 😄

mmarchini pushed a commit that referenced this pull request Feb 26, 2018
@flickzMatheus Marchini
doc: add process.debugPort to doc/api/process.md
65ca369
Fixes: #18639
PR-URL: #18716
Refs: #18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit to addaleax/node that referenced this pull request Feb 26, 2018
@flickz@addaleax
doc: add process.debugPort to doc/api/process.md
b5ecc45
Fixes: nodejs#18639
PR-URL: nodejs#18716
Refs: nodejs#18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax pushed a commit that referenced this pull request Feb 26, 2018
@flickz@addaleax
doc: add process.debugPort to doc/api/process.md
b456e31
Fixes: #18639
PR-URL: #18716
Refs: #18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@addaleaxaddaleax mentioned this pull request Feb 27, 2018
Closed
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@flickz@MayaLekova
doc: add process.debugPort to doc/api/process.md
a3f2e94
Fixes: nodejs#18639
PR-URL: nodejs#18716
Refs: nodejs#18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
jasnell pushed a commit to jasnell/node that referenced this pull request Aug 17, 2018
@flickz@jasnell
doc: add process.debugPort to doc/api/process.md
88adf76
Fixes: nodejs#18639
PR-URL: nodejs#18716
Refs: nodejs#18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Sep 6, 2018
@flickz@MylesBorins
doc: add process.debugPort to doc/api/process.md
dbc5bed
Fixes: #18639
Backport-PR-URL: #22380
PR-URL: #18716
Refs: #18639
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorinsMylesBorins mentioned this pull request Sep 6, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
+2 more reviewers
@daynindaynindaynin approved these changes
@mmarchinimmarchinimmarchini approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@flickz@targos@mmarchini@jasnell@daynin@benjamingr@lpinca@cjihrig@tniessen@BridgeAR@nodejs-github-bot