Uh oh!
There was an error while loading. Please reload this page.
test: fix warnings in addon tests - #18810
Closed
ofrobots wants to merge 1 commit into
Closed
Conversation
The legacy MakeCallback deprecation was resulting in compile time warnings in adddon tests. Fix them. Ref: nodejs#18632
4 tasks
cjihrig
approved these changes
Feb 16, 2018
jasnell
approved these changes
Feb 16, 2018
jasnell
commented
Feb 16, 2018
Member
CI failure appears to be unrelated. As this is a test change, and it has sign off, will land. |
jasnell
commented
Feb 16, 2018
Member
Landed in 6ab288f |
Merged
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
The legacy MakeCallback deprecation was resulting in compile time warnings in adddon tests. Fix them. Ref: nodejs#18632 PR-URL: nodejs#18810 Refs: nodejs#18632 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
commented
Aug 7, 2018
Contributor
I've set as don't land for 8.x, please lmk if this is a mistake |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The legacy MakeCallback deprecation was resulting in compile time
warnings in adddon tests. Fix them.
Ref: #18632
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test
CI: https://ci.nodejs.org/job/node-test-pull-request/13190/