Skip to content

test: http2 client settings invalid callback - #18850

Closed
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:test-http2-client-settings
Closed

test: http2 client settings invalid callback#18850
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:test-http2-client-settings

Conversation

@trivikr

@trivikrtrivikr commented Feb 18, 2018

Copy link
Copy Markdown
Member

This code change adds test for the following line:

node/lib/internal/http2/core.js

Line 1045 in 472cde6

thrownewerrors.TypeError('ERR_INVALID_CALLBACK');

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 18, 2018
@BridgeAR

BridgeAR commented Feb 18, 2018

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/13247/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2018
jasnell pushed a commit that referenced this pull request Feb 20, 2018
@trivikr@jasnell
test: http2 client settings invalid callback
0089860
PR-URL: #18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

jasnell commented Feb 20, 2018

Copy link
Copy Markdown
Member

Landed in 0089860

@jasnelljasnell closed this Feb 20, 2018
@trivikr
trivikr deleted the test-http2-client-settings branch February 20, 2018 15:57
@trivikr
trivikr restored the test-http2-client-settings branch February 20, 2018 15:57
@trivikr
trivikr deleted the test-http2-client-settings branch February 20, 2018 15:58
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@trivikr@MylesBorins
test: http2 client settings invalid callback
bc156da
PR-URL: #18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@trivikr@MylesBorins
test: http2 client settings invalid callback
10f92d1
PR-URL: #18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@trivikr@MylesBorins
test: http2 client settings invalid callback
b02f4e1
PR-URL: #18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@trivikr@MayaLekova
test: http2 client settings invalid callback
8b742cb
PR-URL: nodejs#18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@trivikr@MylesBorins
test: http2 client settings invalid callback
4279c1e
PR-URL: #18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
@trivikr@MylesBorins
test: http2 client settings invalid callback
3a5dd0c
PR-URL: #18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
@trivikr@MylesBorins
test: http2 client settings invalid callback
e4d3ebf
PR-URL: #18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
@trivikr@MylesBorins
test: http2 client settings invalid callback
901f579
PR-URL: #18850
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@daynindaynindaynin approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@trivikr@BridgeAR@jasnell@daynin@lpinca@cjihrig@nodejs-github-bot