Skip to content

test: http2 compat response.write() error checks - #18859

Closed
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:test-http2-compat-write
Closed

test: http2 compat response.write() error checks#18859
trivikr wants to merge 1 commit into
nodejs:masterfrom
trivikr:test-http2-compat-write

Conversation

@trivikr

Copy link
Copy Markdown
Member

This code change adds tests for the following code:

if(typeofencoding==='function'){
cb=encoding;
encoding='utf8';
}
if(this[kState].closed){
consterr=newerrors.Error('ERR_HTTP2_INVALID_STREAM');
if(typeofcb==='function')
process.nextTick(cb,err);
else
throwerr;
return;
}

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 19, 2018

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so long as CI comes back green

@jasnell

Copy link
Copy Markdown
Member

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 21, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 22, 2018
PR-URL: nodejs#18859
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

Copy link
Copy Markdown
Member

Landed in a926c1a 🎉

addaleax pushed a commit to addaleax/node that referenced this pull request Feb 26, 2018
PR-URL: nodejs#18859
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 26, 2018
PR-URL: #18859
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleaxaddaleax mentioned this pull request Feb 27, 2018
@trivikr
trivikr deleted the test-http2-compat-write branch March 8, 2018 14:46
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
PR-URL: nodejs#18859
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 7, 2018
PR-URL: #18859
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
PR-URL: #18859
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Aug 16, 2018
MylesBorins pushed a commit that referenced this pull request Aug 16, 2018
PR-URL: #18859
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@trivikr@jasnell@BridgeAR@MylesBorins@nodejs-github-bot