Uh oh!
There was an error while loading. Please reload this page.
module: replace "magic" numbers by constants - #18869
Closed
daynin wants to merge 1 commit into
Closed
Conversation
cjihrig
approved these changes
Feb 19, 2018
targos
approved these changes
Feb 19, 2018
BridgeAR
approved these changes
Feb 19, 2018
BridgeAR
commented
Feb 19, 2018
Member
mmarchini
approved these changes
Feb 20, 2018
richardlau
commented
Feb 21, 2018
Member
To whoever lands this, the commit title is missing the last |
- add new constants - replace numbers by constants
dayninforce-pushed
the
module-add-constants
branch
from
February 21, 2018 11:16
235f56c to
3353f10Comparedaynin
commented
Feb 21, 2018
ContributorAuthor
@richardlau fixed |
BridgeAR
commented
Feb 22, 2018
Member
Just running a new CI before landing to make sure. Light-CI https://ci.nodejs.org/job/node-test-commit-light/311/ |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Feb 22, 2018
- add new constants - replace numbers by constants PR-URL: nodejs#18869 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
BridgeAR
commented
Feb 22, 2018
Member
Landed in 070a82e 🎉 |
MylesBorins
commented
Mar 6, 2018
Contributor
Should this be backported to /cc @nodejs/modules |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
- add new constants - replace numbers by constants PR-URL: nodejs#18869 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
- add new constants - replace numbers by constants PR-URL: nodejs#18869 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matheus Marchini <matheus@sthima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
module