Uh oh!
There was an error while loading. Please reload this page.
doc: lowercase primitives in test/common/README.md - #18875
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
vsemozhetbyt
commented
Feb 19, 2018
ContributorAuthor
benjamingr
approved these changes
Feb 20, 2018
benjamingr
left a comment
Member
There was a problem hiding this comment.
No strong feelings about it and I don't think it's worth the work so -0, actual changes LGTM.
BridgeAR
approved these changes
Feb 20, 2018
BridgeAR
commented
Feb 20, 2018
Member
Removing the fast-track due to the mentioned concerns. |
joyeecheung
approved these changes
Feb 20, 2018
lpinca
approved these changes
Feb 20, 2018
vsemozhetbyt
commented
Feb 21, 2018
ContributorAuthor
Landed in 48e90ed |
vsemozhetbyt added a commit
that referenced
this pull request
Feb 21, 2018
PR-URL: #18875 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Mar 5, 2018
PR-URL: nodejs#18875 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18875 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, test
Sync the format with the main API docs.