Uh oh!
There was an error while loading. Please reload this page.
test: actually test the ttywrap portion of getasyncid - #18886
Merged
Fishrock123 merged 1 commit intoFeb 22, 2018
Conversation
BridgeAR
approved these changes
Feb 21, 2018
Member
There was a problem hiding this comment.
This could get outdated easily and I doubt that we actually need that comment. The same applies to the other file accordingly.
ContributorAuthor
There was a problem hiding this comment.
imo, better to have something than nothing
Member
There was a problem hiding this comment.
Nit: can we go for camelCase instead? :-)
daynin
approved these changes
Feb 21, 2018
Fishrock123force-pushed
the
actually-test-tty-getasyncid
branch
from
February 21, 2018 19:30
2649289 to
51ea6a9CompareFollow-up from nodejs#18800 Code that tries to exercise tty fds must be placed in `/pseudo-tty/`. PR-URL: nodejs#18886 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Fishrock123force-pushed
the
actually-test-tty-getasyncid
branch
from
February 22, 2018 17:08
51ea6a9 to
af91d94CompareFishrock123
commented
Feb 22, 2018
ContributorAuthor
oops, title was too long. actually landed in 0a26280 |
MylesBorins
commented
Mar 6, 2018
Contributor
Should this be backported to |
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
May 1, 2018
Follow-up from nodejs#18800 Code that tries to exercise tty fds must be placed in `/pseudo-tty/`. PR-URL: nodejs#18886 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Follow-up from nodejs#18800 Code that tries to exercise tty fds must be placed in `/pseudo-tty/`. PR-URL: nodejs#18886 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #18800
Code that tries to exercise tty fds must be placed in
/pseudo-tty/.CI: https://ci.nodejs.org/job/node-test-pull-request/13290/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, tty